From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RFC 3/3] mfd: dt-bindings: Add RK818 device tree bindings document Date: Mon, 11 Apr 2016 17:19:29 +0100 Message-ID: <20160411161929.GZ8094@x1> References: <1460108861-32818-1-git-send-email-w.egorov@phytec.de> <1460108861-32818-4-git-send-email-w.egorov@phytec.de> <20160411084434.GJ4592@x1> <20160411160318.GA6478@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160411160318.GA6478@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Wadim Egorov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Mon, 11 Apr 2016, Rob Herring wrote: > On Mon, Apr 11, 2016 at 09:44:34AM +0100, Lee Jones wrote: > > On Fri, 08 Apr 2016, Wadim Egorov wrote: > >=20 > > > Add device tree bindings documentation for rockchip's RK818 pmic. > > >=20 > > > Signed-off-by: Wadim Egorov > > > --- > > > Documentation/devicetree/bindings/mfd/rk808.txt | 37 +++++++++++= ++++++++++++-- > > > 1 file changed, 34 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Do= cumentation/devicetree/bindings/mfd/rk808.txt > > > index 4ca6aab..8cceb07 100644 > > > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > > > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > > > @@ -1,7 +1,11 @@ > > > -RK808 Power Management Integrated Circuit > > > +RK8xx Power Management Integrated Circuit > >=20 > > s/xx/XX/ >=20 > And others say this bikeshed should be lowercase... >=20 > I say fine as is for bindings. Uppercase for actual part letters,=20 > lowercase for wildcards. =46air enough. NB: It should be fine to bikeshed on an RFC. I could understand your point better if we were coming to completion, or already on v5 or something. > > > +The rk8xx family current members: > > > +rk808 > > > +rk818 > > > =20 > > > Required properties: > > > -- compatible: "rockchip,rk808" > > > +- compatible: "rockchip,rk808", "rockchip,rk818" > > > - reg: I2C slave address > > > - interrupt-parent: The parent interrupt controller. > > > - interrupts: the interrupt outputs of the controller. > > > @@ -13,6 +17,8 @@ Optional properties: > > > default output clock name > > > - rockchip,system-power-controller: Telling whether or not this = pmic is controlling > > > the system power. > > > + > > > +Optional rk808 properties: > >=20 > > When mentioning the chip by name, you should always do so using > > uppercase, as it is in the datasheet. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbcDKQTh (ORCPT ); Mon, 11 Apr 2016 12:19:37 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38321 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcDKQTe (ORCPT ); Mon, 11 Apr 2016 12:19:34 -0400 Date: Mon, 11 Apr 2016 17:19:29 +0100 From: Lee Jones To: Rob Herring Cc: Wadim Egorov , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, dianders@chromium.org, zyw@rock-chips.com Subject: Re: [RFC 3/3] mfd: dt-bindings: Add RK818 device tree bindings document Message-ID: <20160411161929.GZ8094@x1> References: <1460108861-32818-1-git-send-email-w.egorov@phytec.de> <1460108861-32818-4-git-send-email-w.egorov@phytec.de> <20160411084434.GJ4592@x1> <20160411160318.GA6478@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160411160318.GA6478@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Apr 2016, Rob Herring wrote: > On Mon, Apr 11, 2016 at 09:44:34AM +0100, Lee Jones wrote: > > On Fri, 08 Apr 2016, Wadim Egorov wrote: > > > > > Add device tree bindings documentation for rockchip's RK818 pmic. > > > > > > Signed-off-by: Wadim Egorov > > > --- > > > Documentation/devicetree/bindings/mfd/rk808.txt | 37 +++++++++++++++++++++++-- > > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt > > > index 4ca6aab..8cceb07 100644 > > > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > > > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > > > @@ -1,7 +1,11 @@ > > > -RK808 Power Management Integrated Circuit > > > +RK8xx Power Management Integrated Circuit > > > > s/xx/XX/ > > And others say this bikeshed should be lowercase... > > I say fine as is for bindings. Uppercase for actual part letters, > lowercase for wildcards. Fair enough. NB: It should be fine to bikeshed on an RFC. I could understand your point better if we were coming to completion, or already on v5 or something. > > > +The rk8xx family current members: > > > +rk808 > > > +rk818 > > > > > > Required properties: > > > -- compatible: "rockchip,rk808" > > > +- compatible: "rockchip,rk808", "rockchip,rk818" > > > - reg: I2C slave address > > > - interrupt-parent: The parent interrupt controller. > > > - interrupts: the interrupt outputs of the controller. > > > @@ -13,6 +17,8 @@ Optional properties: > > > default output clock name > > > - rockchip,system-power-controller: Telling whether or not this pmic is controlling > > > the system power. > > > + > > > +Optional rk808 properties: > > > > When mentioning the chip by name, you should always do so using > > uppercase, as it is in the datasheet. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog