From: Andi Kleen <andi@firstfloor.org>
To: Eric Paris <eparis@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
linux-audit@redhat.com
Subject: Re: [PATCH] audit: Don't spam logs with SECCOMP_KILL/RET_ERRNO by default
Date: Mon, 11 Apr 2016 14:55:17 -0700 [thread overview]
Message-ID: <20160411215516.GK9407@two.firstfloor.org> (raw)
In-Reply-To: <1460390286.3268.36.camel@redhat.com>
On Mon, Apr 11, 2016 at 10:58:06AM -0500, Eric Paris wrote:
> Just an FYI originally the idea was to follow the pattern of logging
> set by core dumps see kernel/auditsc.c::audit_core_dumps(). Which is
> gated by audit_enable but not anything else. I believe at that time the
> only option was kill, which meant, much like the core dumper, spam was
> not a likely result given the initiator is killed.
Given that user space now uses audit independently for its own
logging I don't think making things depend only on audit_enable
is good practice anymore.
>
> I'm all for a way to shut up unsolicited audit messages, especially
> seccomp with errno or trap. I think it would be best to default 'KILL'
> to on and everything else to off. I'm no so sure a sysctl is the right
> way though. Enabling more forms of 'seccomp audit' should really be a
> part of the audit policy.
That was my original patch -- make it conditional on syscall auditing.
If that's the right approach please apply that one.
-Andi
next prev parent reply other threads:[~2016-04-11 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 4:13 [PATCH] audit: Don't spam logs with SECCOMP_KILL/RET_ERRNO by default Andi Kleen
2016-04-11 4:35 ` kbuild test robot
2016-04-11 5:30 ` kbuild test robot
2016-04-11 13:30 ` Paul Moore
2016-04-11 13:30 ` Paul Moore
2016-04-11 15:58 ` Eric Paris
2016-04-11 21:55 ` Andi Kleen [this message]
2016-04-12 1:17 ` Paul Moore
-- strict thread matches above, loose matches on Subject: below --
2016-04-11 4:43 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411215516.GK9407@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.