From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5009.houston.hp.com (g9t5009.houston.hp.com [15.240.92.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F35B21A1FC8 for ; Mon, 11 Apr 2016 16:59:01 -0700 (PDT) Date: Mon, 11 Apr 2016 17:58:59 -0600 From: Jerry Hoemann Subject: Re: [PATCH v8 09/10] nvdimm: sysfs shows which dsm support full command ioctl. Message-ID: <20160411235859.GD119165@tevye.fc.hp.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jerry.Hoemann@hpe.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "linux-nvdimm@lists.01.org" List-ID: On Mon, Apr 11, 2016 at 02:43:39PM -0700, Dan Williams wrote: > On Mon, Mar 21, 2016 at 12:37 PM, Jerry Hoemann wrote: > > NVDIMM DSMs whose functions map to the Intel Example DSM, can > > be called with the ND_IOCTL_.* ioctl interface. Those that > > don't map, can only be called with the pass thru command. > > > > Save this indication in struct nvdimm to be passed to > > the sysfs interface. > > > > I'm having trouble understanding the intent of cmd_ioctl. I don't > want a flag for "supports Intel Example DSM", I want a mask of ND > commands the bus provider knows how to handle in its ->ndctl() entry > point for the given dimm. The bus provider is free to provide a > translation of ND command to the bus specific command. It's just an > arbitrary coincidence that the current list of ND commands matches the > Intel ACPI _DSM command format. This is my extension of your earlier RFC patch, so I may have misunderstood your original intent. The commands_show functions prints the listing of commands for that device. There is one version for root, and one version for non-root. For root commands, both dsm spec match on names and semantics, so no code works for both nvdimms types. But for non-root commands the names/semantics don't match. So, this is an attempt to show that on an NVDIMM-N, only the pass thru command is supported. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise ----------------------------------------------------------------------------- _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm