All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Jani Nikula <jani.nikula@intel.com>,
	lgirdwood@gmail.com, dri-devel@lists.freedesktop.org,
	patches.audio@intel.com, Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 00/11] ASoC: hdac_hdmi: Add multichannel support
Date: Tue, 12 Apr 2016 11:56:11 +0530	[thread overview]
Message-ID: <20160412062605.GA8655@subhransu-desktop> (raw)
In-Reply-To: <20160412055435.GX3351@sirena.org.uk>

On Tue, Apr 12, 2016 at 06:54:35AM +0100, Mark Brown wrote:
> On Tue, Apr 12, 2016 at 07:43:59AM +0200, Takashi Iwai wrote:
> 
> > But the problem is more complicated because you're changing drm stuff,
> > too.  This is usually managed in drm tree.  So this cross over three
> > different trees.
> 
> The DRM folks tend to leave this up to us, or at least review on any of
> these crossover patches has been extremely light.
> 
> > Do we really need this?  Even the direct reference is pretty much
> > obvious.  e.g. I see no big difference between two lines below:
> > 	spk_alloc = drm_eld_get_spk_alloc(some_eld);
> > 	spk_alloc = some_eld[DRM_ELD_SPAEKER];
> 
> That'd make things even easier of course.

Takashi/Mark, Thanks for the review. Agree, accomodating in the driver is
easier and the inline function doesn't make much difference. I will
accomodate the change in the driver itself.

Shall I repost the series with these changes, which can be reviewed further
or wait for more review comments before reposting?

Regards,
Subhransu

-- 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-04-12  6:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12  5:01 [PATCH 00/11] ASoC: hdac_hdmi: Add multichannel support Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 01/11] ASoC: Intel: Skylake: Fix ibs/obs calc for non-integral sampling rates Subhransu S. Prusty
2016-04-12  6:30   ` Applied "ASoC: Intel: Skylake: Fix ibs/obs calc for non-integral sampling rates" to the asoc tree Mark Brown
2016-04-12  5:01 ` [PATCH 02/11] drm/edid: Add API to get speaker allocation Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 03/11] ASoC: hdac_hdmi: parse eld for channel map capability Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 04/11] ALSA: hda - add helper to get channels from cap bits Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 05/11] ASoC: hdac_hdmi: Add multichannel support Subhransu S. Prusty
2016-04-12 12:25   ` Pierre-Louis Bossart
2016-04-12 13:36     ` Subhransu S. Prusty
2016-04-12 13:50       ` Takashi Iwai
2016-04-12  5:01 ` [PATCH 06/11] ASoC: skl_rt286: Fix to support hdmi channel map support Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 07/11] ASoC: Intel: boards: Update skl_nau88l25_max98357a driver to support chmap Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 08/11] ASoC: Intel: boards: Update skl_nau88l25_ssm4567 " Subhransu S. Prusty
2016-04-12 12:32   ` Pierre-Louis Bossart
2016-04-12 13:51     ` Subhransu S. Prusty
2016-04-12  5:01 ` [PATCH 09/11] ASoC: hdac_hdmi: Register chmap controls and ops Subhransu S. Prusty
2016-04-28 17:55   ` Applied "ASoC: hdac_hdmi: Register chmap controls and ops" to the asoc tree Mark Brown
2016-04-12  5:01 ` [PATCH 10/11] ASoC: Intel: Skylake: Add multichannel support for HDMI Subhransu S. Prusty
2016-04-28 17:55   ` Applied "ASoC: Intel: Skylake: Add multichannel support for HDMI" to the asoc tree Mark Brown
2016-04-12  5:01 ` [PATCH 11/11] ASoC: Intel: Skylake: Update channel map based on runtime params Subhransu S. Prusty
2016-04-28 17:55   ` Applied "ASoC: Intel: Skylake: Update channel map based on runtime params" to the asoc tree Mark Brown
2016-04-12  5:43 ` [PATCH 00/11] ASoC: hdac_hdmi: Add multichannel support Takashi Iwai
2016-04-12  5:54   ` Mark Brown
2016-04-12  6:26     ` Subhransu S. Prusty [this message]
2016-04-12  6:31       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160412062605.GA8655@subhransu-desktop \
    --to=subhransu.s.prusty@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches.audio@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.