From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
Roger Luethi <rl@hellgate.ch>, Arnd Bergmann <arnd@arndb.de>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
David Ahern <dsahern@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Pavel Odintsov <pavel.odintsov@gmail.com>
Subject: Re: [PATCH 04/15] task_diag: add a new interface to get information about tasks (v4)
Date: Tue, 12 Apr 2016 10:08:57 +0300 [thread overview]
Message-ID: <20160412070857.GU2000@uranus.lan> (raw)
In-Reply-To: <1460417755-18201-5-git-send-email-avagin@openvz.org>
On Mon, Apr 11, 2016 at 04:35:44PM -0700, Andrey Vagin wrote:
...
> +static int __taskdiag_dumpit(struct task_iter *iter,
> + struct task_diag_cb *cb, struct task_struct **start)
> +{
> + struct user_namespace *userns = current_user_ns();
> + struct task_struct *task = *start;
> + int rc;
> +
> + for (; task; task = iter_next(iter)) {
> + if (!ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS))
> + continue;
> +
> + rc = task_diag_fill(task, cb->resp, &iter->req,
> + cb, iter->ns, userns);
> + if (rc < 0) {
> + if (rc != -EMSGSIZE)
> + return rc;
> + break;
> + }
> + }
> + *start = task;
task = NULL always here?
> +
> + return 0;
> +}
Cyrill
next prev parent reply other threads:[~2016-04-12 7:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 23:35 [PATCH 0/15] task_diag: add a new interface to get information about processes (v3) Andrey Vagin
2016-04-11 23:35 ` [PATCH 01/15] proc: pick out a function to iterate task children Andrey Vagin
2016-04-11 23:35 ` [PATCH 02/15] proc: export task_first_tid() and task_next_tid() Andrey Vagin
2016-04-11 23:35 ` [PATCH 03/15] proc: export next_tgid() Andrey Vagin
2016-04-11 23:35 ` [PATCH 04/15] task_diag: add a new interface to get information about tasks (v4) Andrey Vagin
2016-04-12 1:03 ` kbuild test robot
2016-04-13 0:45 ` Andrew Vagin
2016-04-12 7:08 ` Cyrill Gorcunov [this message]
2016-04-13 0:39 ` Andrew Vagin
2016-04-13 5:26 ` Cyrill Gorcunov
2016-04-11 23:35 ` [PATCH 05/15] task_diag: add a new group to get process credentials Andrey Vagin
2016-04-11 23:35 ` [PATCH 06/15] task_diag: add a new group to get tasks memory mappings (v2) Andrey Vagin
2016-04-11 23:35 ` [PATCH 07/15] task_diag: add ability to dump children and threads Andrey Vagin
2016-04-11 23:35 ` [PATCH 08/15] task_diag: Only add VMAs for thread_group leader Andrey Vagin
2016-04-11 23:35 ` [PATCH 09/15] task_diag: add a flag to mark incomplete messages Andrey Vagin
2016-04-11 23:35 ` [PATCH 10/15] task_diag: add a new group to get resource usage Andrey Vagin
2016-04-11 23:35 ` [PATCH 11/15] task_diag: add a new group to get memory usage Andrey Vagin
2016-04-11 23:35 ` [PATCH 12/15] Documentation: add documentation for task_diag Andrey Vagin
2016-04-11 23:35 ` [PATCH 13/15] selftest: check the task_diag functinonality Andrey Vagin
2016-04-11 23:35 ` [PATCH 14/15] task_diag: Enhance fork tool to spawn threads Andrey Vagin
2016-04-11 23:35 ` [PATCH 15/15] test: check that task_diag can dump all thread of one process Andrey Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412070857.GU2000@uranus.lan \
--to=gorcunov@gmail.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=avagin@openvz.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=pavel.odintsov@gmail.com \
--cc=rl@hellgate.ch \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.