From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH RFC 04/11] drm/tilcdc: Add tilcdc_crtc_mode_set_nofb() Date: Tue, 12 Apr 2016 18:13:23 +0200 Message-ID: <20160412161322.GL2510@phenom.ffwll.local> References: <6ec1835d08c210602178970af10c80db7a6650db.1460380199.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D5CE89A56 for ; Tue, 12 Apr 2016 16:13:07 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id l6so6692618wml.3 for ; Tue, 12 Apr 2016 09:13:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6ec1835d08c210602178970af10c80db7a6650db.1460380199.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha Cc: dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMTEsIDIwMTYgYXQgMDc6NDY6MzFQTSArMDMwMCwgSnlyaSBTYXJoYSB3cm90 ZToKPiBBZGQgdGlsY2RjX2NydGNfbW9kZV9zZXRfbm9mYigpLiBUaGUgbW9kZV9zZXRfbm9mYigp IHNlbWFudGljcyBkbyBub3QKPiBmaXQgd2VsbCB0byBMQ0RDLCBiZWNhdXNlIG9mIHRoZSBtYW5k YXRvcnkgZnJhbWVidWZmZXIuIEhvd2V2ZXIsIHdoZW4KPiB0aGUgcHJpbWFyeSBwbGFuZSBpcyBy ZXF1aXJlZCBpbiB0aGUgY2hlY2sgcGhhc2UsIGl0IGFuZCB0aGUKPiBmcmFtZWJ1ZmZlciBjYW4g YmUgZm91bmQgZnJvbSB0aGUgYXRvbWljIHN0YXRlIHN0cnVjdC4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBKeXJpIFNhcmhhIDxqc2FyaGFAdGkuY29tPgoKWWVhaCwgaWYgeW91ciBodyBhbHdheXMgcmVx dWlyZXMgYSBwcmltYXJ5IHBsYW5lIHRoZW4gMiBiaXRzIG5lZWRlZDogYSkKbWFrZSBzdXJlIGlu IHRoZSBjcnRjJ3MgYXRvbWljX2NoZWNrIGl0J3MgdGhlcmUgYW5kIHNldCBiKSBqdXN0IHVzZSB0 aGUKaG9va3Mgd2hvZXZlciB5b3Ugd2FudCB0by4gQXRvbWljIGFsbG93cyBwbGFuZXMgdG8gYmUg ZW50aXJlbHkgaW5kZXBlbmRlbnQKb2YgdGhlIGRpc3BsYXkgcGlwZWxpbmUsIGJ1dCBkb2Vzbid0 IHJlcXVpcmUgaXQgcmVhbGx5LgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdGls Y2RjL3RpbGNkY19jcnRjLmMgfCAxNzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPiAgMSBmaWxlIGNoYW5nZWQsIDE3MiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS90 aWxjZGMvdGlsY2RjX2NydGMuYwo+IGluZGV4IDkxOWM5MDEuLjM1ZjU2ODIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3RpbGNkYy90aWxjZGNfY3J0Yy5jCj4gQEAgLTMxMCw2ICszMTAsMTc3IEBAIHN0YXRp YyB2b2lkIHRpbGNkY19jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAl0aWxj ZGNfY3J0Y19kcG1zKGNydGMsIERSTV9NT0RFX0RQTVNfT04pOwo+ICB9Cj4gIAo+ICtzdGF0aWMg dm9pZCB0aWxjZGNfY3J0Y19tb2RlX3NldF9ub2ZiKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAr ewo+ICsJc3RydWN0IHRpbGNkY19jcnRjICp0aWxjZGNfY3J0YyA9IHRvX3RpbGNkY19jcnRjKGNy dGMpOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiArCXN0cnVjdCB0 aWxjZGNfZHJtX3ByaXZhdGUgKnByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICsJY29uc3Qgc3Ry dWN0IHRpbGNkY19wYW5lbF9pbmZvICppbmZvID0gdGlsY2RjX2NydGMtPmluZm87Cj4gKwl1aW50 MzJfdCByZWcsIGhicCwgaGZwLCBoc3csIHZicCwgdmZwLCB2c3c7Cj4gKwlzdHJ1Y3QgZHJtX2Rp c3BsYXlfbW9kZSAqbW9kZSA9ICZjcnRjLT5zdGF0ZS0+YWRqdXN0ZWRfbW9kZTsKPiArCXN0cnVj dCBkcm1fZnJhbWVidWZmZXIgKmZiID0gY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPmZiOwo+ICsKPiAr CWlmIChXQVJOX09OKCFpbmZvKSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWYgKFdBUk5fT04oIWZi KSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJcG1fcnVudGltZV9nZXRfc3luYyhkZXYtPmRldik7Cj4g Kwo+ICsJLyogQ29uZmlndXJlIHRoZSBCdXJzdCBTaXplIGFuZCBmaWZvIHRocmVzaG9sZCBvZiBE TUE6ICovCj4gKwlyZWcgPSB0aWxjZGNfcmVhZChkZXYsIExDRENfRE1BX0NUUkxfUkVHKSAmIH4w eDAwMDAwNzcwOwo+ICsJc3dpdGNoIChpbmZvLT5kbWFfYnVyc3Rfc3opIHsKPiArCWNhc2UgMToK PiArCQlyZWcgfD0gTENEQ19ETUFfQlVSU1RfU0laRShMQ0RDX0RNQV9CVVJTVF8xKTsKPiArCQli cmVhazsKPiArCWNhc2UgMjoKPiArCQlyZWcgfD0gTENEQ19ETUFfQlVSU1RfU0laRShMQ0RDX0RN QV9CVVJTVF8yKTsKPiArCQlicmVhazsKPiArCWNhc2UgNDoKPiArCQlyZWcgfD0gTENEQ19ETUFf QlVSU1RfU0laRShMQ0RDX0RNQV9CVVJTVF80KTsKPiArCQlicmVhazsKPiArCWNhc2UgODoKPiAr CQlyZWcgfD0gTENEQ19ETUFfQlVSU1RfU0laRShMQ0RDX0RNQV9CVVJTVF84KTsKPiArCQlicmVh azsKPiArCWNhc2UgMTY6Cj4gKwkJcmVnIHw9IExDRENfRE1BX0JVUlNUX1NJWkUoTENEQ19ETUFf QlVSU1RfMTYpOwo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlkZXZfZXJyKGRldi0+ZGV2 LCAiaW52YWxpZCBidXJzdCBzaXplXG4iKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwlyZWcgfD0g KGluZm8tPmZpZm9fdGggPDwgOCk7Cj4gKwl0aWxjZGNfd3JpdGUoZGV2LCBMQ0RDX0RNQV9DVFJM X1JFRywgcmVnKTsKPiArCj4gKwkvKiBDb25maWd1cmUgdGltaW5nczogKi8KPiArCWhicCA9IG1v ZGUtPmh0b3RhbCAtIG1vZGUtPmhzeW5jX2VuZDsKPiArCWhmcCA9IG1vZGUtPmhzeW5jX3N0YXJ0 IC0gbW9kZS0+aGRpc3BsYXk7Cj4gKwloc3cgPSBtb2RlLT5oc3luY19lbmQgLSBtb2RlLT5oc3lu Y19zdGFydDsKPiArCXZicCA9IG1vZGUtPnZ0b3RhbCAtIG1vZGUtPnZzeW5jX2VuZDsKPiArCXZm cCA9IG1vZGUtPnZzeW5jX3N0YXJ0IC0gbW9kZS0+dmRpc3BsYXk7Cj4gKwl2c3cgPSBtb2RlLT52 c3luY19lbmQgLSBtb2RlLT52c3luY19zdGFydDsKPiArCj4gKwlEQkcoIiVkeCVkLCBoYnA9JXUs IGhmcD0ldSwgaHN3PSV1LCB2YnA9JXUsIHZmcD0ldSwgdnN3PSV1IiwKPiArCSAgICBtb2RlLT5o ZGlzcGxheSwgbW9kZS0+dmRpc3BsYXksIGhicCwgaGZwLCBoc3csIHZicCwgdmZwLCB2c3cpOwo+ ICsKPiArCS8qIFNldCBBQyBCaWFzIFBlcmlvZCBhbmQgTnVtYmVyIG9mIFRyYW5zaXRpb25zIHBl ciBJbnRlcnJ1cHQ6ICovCj4gKwlyZWcgPSB0aWxjZGNfcmVhZChkZXYsIExDRENfUkFTVEVSX1RJ TUlOR18yX1JFRykgJiB+MHgwMDBmZmYwMDsKPiArCXJlZyB8PSBMQ0RDX0FDX0JJQVNfRlJFUVVF TkNZKGluZm8tPmFjX2JpYXMpIHwKPiArCQlMQ0RDX0FDX0JJQVNfVFJBTlNJVElPTlNfUEVSX0lO VChpbmZvLT5hY19iaWFzX2ludHJwdCk7Cj4gKwo+ICsJLyoKPiArCSAqIHN1YnRyYWN0IG9uZSBm cm9tIGhmcCwgaGJwLCBoc3cgYmVjYXVzZSB0aGUgaGFyZHdhcmUgdXNlcwo+ICsJICogYSB2YWx1 ZSBvZiAwIGFzIDEKPiArCSAqLwo+ICsJaWYgKHByaXYtPnJldiA9PSAyKSB7Cj4gKwkJLyogY2xl YXIgYml0cyB3ZSdyZSBnb2luZyB0byBzZXQgKi8KPiArCQlyZWcgJj0gfjB4NzgwMDAwMzM7Cj4g KwkJcmVnIHw9ICgoaGZwLTEpICYgMHgzMDApID4+IDg7Cj4gKwkJcmVnIHw9ICgoaGJwLTEpICYg MHgzMDApID4+IDQ7Cj4gKwkJcmVnIHw9ICgoaHN3LTEpICYgMHgzYzApIDw8IDIxOwo+ICsJfQo+ ICsJdGlsY2RjX3dyaXRlKGRldiwgTENEQ19SQVNURVJfVElNSU5HXzJfUkVHLCByZWcpOwo+ICsK PiArCXJlZyA9ICgoKG1vZGUtPmhkaXNwbGF5ID4+IDQpIC0gMSkgPDwgNCkgfAo+ICsJCSgoKGhi cC0xKSAmIDB4ZmYpIDw8IDI0KSB8Cj4gKwkJKCgoaGZwLTEpICYgMHhmZikgPDwgMTYpIHwKPiAr CQkoKChoc3ctMSkgJiAweDNmKSA8PCAxMCk7Cj4gKwlpZiAocHJpdi0+cmV2ID09IDIpCj4gKwkJ cmVnIHw9ICgoKG1vZGUtPmhkaXNwbGF5ID4+IDQpIC0gMSkgJiAweDQwKSA+PiAzOwo+ICsJdGls Y2RjX3dyaXRlKGRldiwgTENEQ19SQVNURVJfVElNSU5HXzBfUkVHLCByZWcpOwo+ICsKPiArCXJl ZyA9ICgobW9kZS0+dmRpc3BsYXkgLSAxKSAmIDB4M2ZmKSB8Cj4gKwkJKCh2YnAgJiAweGZmKSA8 PCAyNCkgfAo+ICsJCSgodmZwICYgMHhmZikgPDwgMTYpIHwKPiArCQkoKCh2c3ctMSkgJiAweDNm KSA8PCAxMCk7Cj4gKwl0aWxjZGNfd3JpdGUoZGV2LCBMQ0RDX1JBU1RFUl9USU1JTkdfMV9SRUcs IHJlZyk7Cj4gKwo+ICsJLyoKPiArCSAqIGJlIHN1cmUgdG8gc2V0IEJpdCAxMCBmb3IgdGhlIFYy IExDREMgY29udHJvbGxlciwKPiArCSAqIG90aGVyd2lzZSBsaW1pdGVkIHRvIDEwMjQgcGl4ZWxz IHdpZHRoLCBzdG9wcGluZwo+ICsJICogMTkyMHgxMDgwIGJlaW5nIHN1cHBvcnRlZC4KPiArCSAq Lwo+ICsJaWYgKHByaXYtPnJldiA9PSAyKSB7Cj4gKwkJaWYgKChtb2RlLT52ZGlzcGxheSAtIDEp ICYgMHg0MDApIHsKPiArCQkJdGlsY2RjX3NldChkZXYsIExDRENfUkFTVEVSX1RJTUlOR18yX1JF RywKPiArCQkJCUxDRENfTFBQX0IxMCk7Cj4gKwkJfSBlbHNlIHsKPiArCQkJdGlsY2RjX2NsZWFy KGRldiwgTENEQ19SQVNURVJfVElNSU5HXzJfUkVHLAo+ICsJCQkJTENEQ19MUFBfQjEwKTsKPiAr CQl9Cj4gKwl9Cj4gKwo+ICsJLyogQ29uZmlndXJlIGRpc3BsYXkgdHlwZTogKi8KPiArCXJlZyA9 IHRpbGNkY19yZWFkKGRldiwgTENEQ19SQVNURVJfQ1RSTF9SRUcpICYKPiArCQl+KExDRENfVEZU X01PREUgfCBMQ0RDX01PTk9fOEJJVF9NT0RFIHwgTENEQ19NT05PQ0hST01FX01PREUgfAo+ICsJ CSAgTENEQ19WMl9URlRfMjRCUFBfTU9ERSB8IExDRENfVjJfVEZUXzI0QlBQX1VOUEFDSyB8Cj4g KwkJICAweDAwMGZmMDAwIC8qIFBhbGV0dGUgTG9hZGluZyBEZWxheSBiaXRzICovKTsKPiArCXJl ZyB8PSBMQ0RDX1RGVF9NT0RFOyAvKiBubyBtb25vY2hyb21lL3Bhc3NpdmUgc3VwcG9ydCAqLwo+ ICsJaWYgKGluZm8tPnRmdF9hbHRfbW9kZSkKPiArCQlyZWcgfD0gTENEQ19URlRfQUxUX0VOQUJM RTsKPiArCWlmIChwcml2LT5yZXYgPT0gMikgewo+ICsJCXVuc2lnbmVkIGludCBkZXB0aCwgYnBw Owo+ICsKPiArCQlkcm1fZmJfZ2V0X2JwcF9kZXB0aChmYi0+cGl4ZWxfZm9ybWF0LCAmZGVwdGgs ICZicHApOwo+ICsJCXN3aXRjaCAoYnBwKSB7Cj4gKwkJY2FzZSAxNjoKPiArCQkJYnJlYWs7Cj4g KwkJY2FzZSAzMjoKPiArCQkJcmVnIHw9IExDRENfVjJfVEZUXzI0QlBQX1VOUEFDSzsKPiArCQkJ LyogZmFsbHRocm91Z2ggKi8KPiArCQljYXNlIDI0Ogo+ICsJCQlyZWcgfD0gTENEQ19WMl9URlRf MjRCUFBfTU9ERTsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJZGV2X2VycihkZXYt PmRldiwgImludmFsaWQgcGl4ZWwgZm9ybWF0XG4iKTsKPiArCQkJcmV0dXJuOwo+ICsJCX0KPiAr CX0KPiArCXJlZyB8PSBpbmZvLT5mZGQgPCAxMjsKPiArCXRpbGNkY193cml0ZShkZXYsIExDRENf UkFTVEVSX0NUUkxfUkVHLCByZWcpOwo+ICsKPiArCWlmIChpbmZvLT5pbnZlcnRfcHhsX2NsaykK PiArCQl0aWxjZGNfc2V0KGRldiwgTENEQ19SQVNURVJfVElNSU5HXzJfUkVHLCBMQ0RDX0lOVkVS VF9QSVhFTF9DTE9DSyk7Cj4gKwllbHNlCj4gKwkJdGlsY2RjX2NsZWFyKGRldiwgTENEQ19SQVNU RVJfVElNSU5HXzJfUkVHLCBMQ0RDX0lOVkVSVF9QSVhFTF9DTE9DSyk7Cj4gKwo+ICsJaWYgKGlu Zm8tPnN5bmNfY3RybCkKPiArCQl0aWxjZGNfc2V0KGRldiwgTENEQ19SQVNURVJfVElNSU5HXzJf UkVHLCBMQ0RDX1NZTkNfQ1RSTCk7Cj4gKwllbHNlCj4gKwkJdGlsY2RjX2NsZWFyKGRldiwgTENE Q19SQVNURVJfVElNSU5HXzJfUkVHLCBMQ0RDX1NZTkNfQ1RSTCk7Cj4gKwo+ICsJaWYgKGluZm8t PnN5bmNfZWRnZSkKPiArCQl0aWxjZGNfc2V0KGRldiwgTENEQ19SQVNURVJfVElNSU5HXzJfUkVH LCBMQ0RDX1NZTkNfRURHRSk7Cj4gKwllbHNlCj4gKwkJdGlsY2RjX2NsZWFyKGRldiwgTENEQ19S QVNURVJfVElNSU5HXzJfUkVHLCBMQ0RDX1NZTkNfRURHRSk7Cj4gKwo+ICsJaWYgKG1vZGUtPmZs YWdzICYgRFJNX01PREVfRkxBR19OSFNZTkMpCj4gKwkJdGlsY2RjX3NldChkZXYsIExDRENfUkFT VEVSX1RJTUlOR18yX1JFRywgTENEQ19JTlZFUlRfSFNZTkMpOwo+ICsJZWxzZQo+ICsJCXRpbGNk Y19jbGVhcihkZXYsIExDRENfUkFTVEVSX1RJTUlOR18yX1JFRywgTENEQ19JTlZFUlRfSFNZTkMp Owo+ICsKPiArCWlmIChtb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfTlZTWU5DKQo+ICsJCXRp bGNkY19zZXQoZGV2LCBMQ0RDX1JBU1RFUl9USU1JTkdfMl9SRUcsIExDRENfSU5WRVJUX1ZTWU5D KTsKPiArCWVsc2UKPiArCQl0aWxjZGNfY2xlYXIoZGV2LCBMQ0RDX1JBU1RFUl9USU1JTkdfMl9S RUcsIExDRENfSU5WRVJUX1ZTWU5DKTsKPiArCj4gKwlpZiAoaW5mby0+cmFzdGVyX29yZGVyKQo+ ICsJCXRpbGNkY19zZXQoZGV2LCBMQ0RDX1JBU1RFUl9DVFJMX1JFRywgTENEQ19SQVNURVJfT1JE RVIpOwo+ICsJZWxzZQo+ICsJCXRpbGNkY19jbGVhcihkZXYsIExDRENfUkFTVEVSX0NUUkxfUkVH LCBMQ0RDX1JBU1RFUl9PUkRFUik7Cj4gKwo+ICsJZHJtX2ZyYW1lYnVmZmVyX3JlZmVyZW5jZShm Yik7Cj4gKwo+ICsJc2V0X3NjYW5vdXQoY3J0YywgZmIpOwo+ICsKPiArCXRpbGNkY19jcnRjX3Vw ZGF0ZV9jbGsoY3J0Yyk7Cj4gKwo+ICsJcG1fcnVudGltZV9wdXRfc3luYyhkZXYtPmRldik7Cj4g Kwo+ICsJY3J0Yy0+aHdtb2RlID0gY3J0Yy0+c3RhdGUtPmFkanVzdGVkX21vZGU7Cj4gK30KPiAr Cj4gIHN0YXRpYyBpbnQgdGlsY2RjX2NydGNfbW9kZV9zZXQoc3RydWN0IGRybV9jcnRjICpjcnRj LAo+ICAJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICAJCXN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICphZGp1c3RlZF9tb2RlLAo+IEBAIC01MjYsNiArNjk3LDcgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgdGlsY2RjX2NydGNfaGVscGVyX2Z1bmNz ID0gewo+ICAJCS5jb21taXQgICAgICAgICA9IHRpbGNkY19jcnRjX2NvbW1pdCwKPiAgCQkubW9k ZV9zZXQgICAgICAgPSB0aWxjZGNfY3J0Y19tb2RlX3NldCwKPiAgCQkubW9kZV9zZXRfYmFzZSAg PSB0aWxjZGNfY3J0Y19tb2RlX3NldF9iYXNlLAo+ICsJCS5tb2RlX3NldF9ub2ZiCT0gdGlsY2Rj X2NydGNfbW9kZV9zZXRfbm9mYiwKPiAgfTsKPiAgCj4gIGludCB0aWxjZGNfY3J0Y19tYXhfd2lk dGgoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+IC0tIAo+IDEuOS4xCj4gCgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==