From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: fix crash in tpm_tis deinitialization Date: Tue, 12 Apr 2016 11:26:55 -0600 Message-ID: <20160412172655.GA5759@obsidianresearch.com> References: <1460390720-9509-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160411174037.GA371@obsidianresearch.com> <20160412042627.GA6608@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160412042627.GA6608-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: "moderated list:TPM DEVICE DRIVER" , open list List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Apr 12, 2016 at 07:26:27AM +0300, Jarkko Sakkinen wrote: > > This needs to be after ops is fenced, something like this. > > I would appreciate a supporting argument. > > I guess the argument here is that this will prevent user space from > issuing TPM commands after the shutdown command has been sent? It prevents everything including the kernel from issuing a command after shutdown. The shutdown is sent as the last command and no other commands can follow it. It doesn't make any sense to allow commands to follow shutdown. Jason ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966121AbcDLR1I (ORCPT ); Tue, 12 Apr 2016 13:27:08 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:54416 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932534AbcDLR1H (ORCPT ); Tue, 12 Apr 2016 13:27:07 -0400 Date: Tue, 12 Apr 2016 11:26:55 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: fix crash in tpm_tis deinitialization Message-ID: <20160412172655.GA5759@obsidianresearch.com> References: <1460390720-9509-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160411174037.GA371@obsidianresearch.com> <20160412042627.GA6608@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160412042627.GA6608@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2016 at 07:26:27AM +0300, Jarkko Sakkinen wrote: > > This needs to be after ops is fenced, something like this. > > I would appreciate a supporting argument. > > I guess the argument here is that this will prevent user space from > issuing TPM commands after the shutdown command has been sent? It prevents everything including the kernel from issuing a command after shutdown. The shutdown is sent as the last command and no other commands can follow it. It doesn't make any sense to allow commands to follow shutdown. Jason