All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: util-linux@vger.kernel.org
Subject: libmount python bindings and header includes
Date: Tue, 12 Apr 2016 13:46:53 -0400	[thread overview]
Message-ID: <20160412174653.GA6588@vapier.lan> (raw)

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

i'm currently seeing these build warnings:
libmount/python/fs.c:110:40: warning: implicit declaration of function 'major'
libmount/python/fs.c:111:7: warning: implicit declaration of function 'minor'

this is handled for most of the code in include/c.h:
#ifdef HAVE_SYS_SYSMACROS_H
# include <sys/sysmacros.h>     /* for major, minor */
#endif

but the python code doesn't include that header.  i'm not sure what the
preference is here (make the python code pull in that header or just copy
over the sysmacros.h logic), so i'm skipping writing a patch.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2016-04-12 17:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 17:46 Mike Frysinger [this message]
2016-04-18 11:22 ` libmount python bindings and header includes Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160412174653.GA6588@vapier.lan \
    --to=vapier@gentoo.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.