From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC][PATCH 2/2] drm/arm: Add support for Mali Display Processors Date: Tue, 12 Apr 2016 21:31:28 +0200 Message-ID: <20160412193128.GO2510@phenom.ffwll.local> References: <1459527712-9488-1-git-send-email-Liviu.Dudau@arm.com> <1459527712-9488-3-git-send-email-Liviu.Dudau@arm.com> <20160412155810.GH2510@phenom.ffwll.local> <20160412171654.GL16063@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160412171654.GL16063@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: devicetree@vger.kernel.org, LKML , DRI devel List-Id: devicetree@vger.kernel.org T24gVHVlLCBBcHIgMTIsIDIwMTYgYXQgMDY6MTY6NTRQTSArMDEwMCwgTGl2aXUgRHVkYXUgd3Jv dGU6Cj4gT24gVHVlLCBBcHIgMTIsIDIwMTYgYXQgMDU6NTg6MTFQTSArMDIwMCwgRGFuaWVsIFZl dHRlciB3cm90ZToKPiA+IE9uIEZyaSwgQXByIDAxLCAyMDE2IGF0IDA1OjIxOjUyUE0gKzAxMDAs IExpdml1IER1ZGF1IHdyb3RlOgo+ID4gPiBBZGQgc3VwcG9ydCBmb3IgdGhlIG5ldyBmYW1pbHkg b2YgRGlzcGxheSBQcm9jZXNzb3JzIGZyb20gQVJNIEx0ZC4KPiA+ID4gVGhpcyBjb21taXQgYWRk cyBiYXNpYyBzdXBwb3J0IGZvciBNYWxpIERQNTAwLCBEUDU1MCBhbmQgRFA2NTAKPiA+ID4gcGFy dHMsIHdpdGggb25seSB0aGUgZGlzcGxheSBlbmdpbmUgYmVpbmcgc3VwcG9ydGVkIGF0IHRoZSBt b21lbnQuCj4gPiA+IAo+ID4gPiBDYzogRGF2aWQgQnJvd24gPERhdmlkLkJyb3duQGFybS5jb20+ Cj4gPiA+IENjOiBCcmlhbiBTdGFya2V5IDxCcmlhbi5TdGFya2V5QGFybS5jb20+Cj4gPiA+IAo+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBMaXZpdSBEdWRhdSA8TGl2aXUuRHVkYXVAYXJtLmNvbT4KPiA+ IAo+ID4gT2ssIG9uIDJuZCBsb29rIHNvbWV0aGluZyBwdXp6bGluZzogV2hlcmUgYXJlIHRoZQo+ ID4gZHJtX2VuY29kZXIvZHJtX2Nvbm5lY3RvcnMgaW4gdGhpcyBkcml2ZXI/IFNvbWVob3cgSSB0 aGluayBqdXN0IHRoZXNlCj4gPiBwYXJ0cyBoZXJlIHdvbid0IGxpZ2h0IHVwIGEgbG90IC4uLgo+ IAo+IFRoZSBtYWdpYyBvZiBjb21wb25lbnQgYmFzZWQgZHJpdmVycywgaGVoIDopCj4gCj4gT24g bXkgdGVzdCBzeXN0ZW0gSSdtIHVzaW5nIHRoZSBOWFAgVERBMTk5ODggSERNSSBhbmQgdGhlIGRy aXZlciB3b3Jrcwo+IG91dCBvZiBib3ggb25jZSB0aGUgRFQgZGVzY3JpYmVzIHRoZSBwcm9wZXIg cG9ydC9lbmRwb2ludCBkYW5jZS4gRm9yCj4gbW9kZWxzL3FlbXUgc3R5bGUgZW52aXJvbm1lbnQg SSBoYXZlIGEgZ2VuZXJpYyBEUk0gZW5jb2RlciBkcml2ZXIgdGhhdCBJJ20KPiBnb2luZyB0byBw b3N0IGZvciByZXZpZXcgdGhhdCBvbmx5IHJlYWRzIGRpc3BsYXkgdGltaW5ncyBmcm9tIERUIGFu ZCBiZWhhdmVzCj4gYXMgaWYgaXQgY29ubmVjdGVkIHRvIGEgcmVhbCBtb25pdG9yLgoKSSBkaWRu J3Qga25vdyB0aGF0IG1hZ2ljIHdvcmtlZCBzbyB3ZWxsIGFscmVhZHkuIFNlcmlvdXNseSBpbXBy ZXNzZWQsIGFuZApoYXBweSB0aGF0IGl0IGRvZXNuJ3QgdGFrZSBhbnl0aGluZyBpbiBhZGRpdGlv biB0byBtYWtlIGl0IGFsbCBqdXN0IHdvcmsuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965675AbcDLTbO (ORCPT ); Tue, 12 Apr 2016 15:31:14 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34172 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933789AbcDLTbM (ORCPT ); Tue, 12 Apr 2016 15:31:12 -0400 Date: Tue, 12 Apr 2016 21:31:28 +0200 From: Daniel Vetter To: Liviu Dudau Cc: Dave Airlie , Daniel Stone , David Brown , Brian Starkey , devicetree@vger.kernel.org, LKML , DRI devel Subject: Re: [RFC][PATCH 2/2] drm/arm: Add support for Mali Display Processors Message-ID: <20160412193128.GO2510@phenom.ffwll.local> Mail-Followup-To: Liviu Dudau , Dave Airlie , Daniel Stone , David Brown , Brian Starkey , devicetree@vger.kernel.org, LKML , DRI devel References: <1459527712-9488-1-git-send-email-Liviu.Dudau@arm.com> <1459527712-9488-3-git-send-email-Liviu.Dudau@arm.com> <20160412155810.GH2510@phenom.ffwll.local> <20160412171654.GL16063@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160412171654.GL16063@e106497-lin.cambridge.arm.com> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2016 at 06:16:54PM +0100, Liviu Dudau wrote: > On Tue, Apr 12, 2016 at 05:58:11PM +0200, Daniel Vetter wrote: > > On Fri, Apr 01, 2016 at 05:21:52PM +0100, Liviu Dudau wrote: > > > Add support for the new family of Display Processors from ARM Ltd. > > > This commit adds basic support for Mali DP500, DP550 and DP650 > > > parts, with only the display engine being supported at the moment. > > > > > > Cc: David Brown > > > Cc: Brian Starkey > > > > > > Signed-off-by: Liviu Dudau > > > > Ok, on 2nd look something puzzling: Where are the > > drm_encoder/drm_connectors in this driver? Somehow I think just these > > parts here won't light up a lot ... > > The magic of component based drivers, heh :) > > On my test system I'm using the NXP TDA19988 HDMI and the driver works > out of box once the DT describes the proper port/endpoint dance. For > models/qemu style environment I have a generic DRM encoder driver that I'm > going to post for review that only reads display timings from DT and behaves > as if it connected to a real monitor. I didn't know that magic worked so well already. Seriously impressed, and happy that it doesn't take anything in addition to make it all just work. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch