From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tina Ruchandani Subject: [PATCH] drm/sti: Use 64-bit timestamps Date: Wed, 13 Apr 2016 02:28:02 -0700 Message-ID: <20160413092802.GA99759@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Arnd Bergmann Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Benjamin Gaignard , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org J3N0cnVjdCB0aW1lc3BlYycgdXNlcyBhIDMyLWJpdCBmaWVsZCBmb3Igc2Vjb25kcywgd2hpY2gK d2lsbCBvdmVyZmxvdyBpbiB5ZWFyIDIwMzggYW5kIGJleW9uZC4gVGhpcyBwYXRjaCBpcyBwYXJ0 Cm9mIGEgbGFyZ2VyIGF0dGVtcHQgdG8gcmVtb3ZlIGluc3RhbmNlcyBvZiB0aW1ldmFsLCB0aW1l c3BlYwphbmQgdGltZV90LCBhbGwgb2Ygd2hpY2ggc3VmZmVyIGZyb20gdGhlIHkyMDM4IGlzc3Vl LCBmcm9tIHRoZQprZXJuZWwuCgpTaWduZWQtb2ZmLWJ5OiBUaW5hIFJ1Y2hhbmRhbmkgPHJ1Y2hh bmRhbmkudGluYUBnbWFpbC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfcGxhbmUu YyB8IDE2ICsrKy0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3BsYW5lLmgg fCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3BsYW5lLmMgYi9kcml2ZXJz L2dwdS9kcm0vc3RpL3N0aV9wbGFuZS5jCmluZGV4IGYxMGM5OGQuLjNiNDY4OTkgMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3BsYW5lLmMKKysrIGIvZHJpdmVycy9ncHUvZHJt L3N0aS9zdGlfcGxhbmUuYwpAQCAtNDUsMjUgKzQ1LDE1IEBAIGNvbnN0IGNoYXIgKnN0aV9wbGFu ZV90b19zdHIoc3RydWN0IHN0aV9wbGFuZSAqcGxhbmUpCgogI2RlZmluZSBTVElfRlBTX0lOVEVS VkFMX01TICAgICAzMDAwCgotc3RhdGljIGludCBzdGlfcGxhbmVfdGltZXNwZWNfbXNfZGlmZihz dHJ1Y3QgdGltZXNwZWMgbGhzLCBzdHJ1Y3QgdGltZXNwZWMgcmhzKQotewotCXN0cnVjdCB0aW1l c3BlYyB0bXBfdHMgPSB0aW1lc3BlY19zdWIobGhzLCByaHMpOwotCXU2NCB0bXBfbnMgPSAodTY0 KXRpbWVzcGVjX3RvX25zKCZ0bXBfdHMpOwotCi0JZG9fZGl2KHRtcF9ucywgTlNFQ19QRVJfTVNF Qyk7Ci0KLQlyZXR1cm4gKHUzMil0bXBfbnM7Ci19Ci0KIHZvaWQgc3RpX3BsYW5lX3VwZGF0ZV9m cHMoc3RydWN0IHN0aV9wbGFuZSAqcGxhbmUsCiAJCQkgIGJvb2wgbmV3X2ZyYW1lLAogCQkJICBi b29sIG5ld19maWVsZCkKIHsKLQlzdHJ1Y3QgdGltZXNwZWMgbm93OworCWt0aW1lX3Qgbm93Owog CXN0cnVjdCBzdGlfZnBzX2luZm8gKmZwczsKIAlpbnQgZnBrcywgZmlwa3MsIG1zX3NpbmNlX2xh c3QsIG51bV9mcmFtZXMsIG51bV9maWVsZHM7CgotCWdldHJhd21vbm90b25pYygmbm93KTsKKwlu b3cgPSBrdGltZV9nZXQoKTsKCiAJLyogQ29tcHV0ZSBudW1iZXIgb2YgZnJhbWUgdXBkYXRlcyAq LwogCWZwcyA9ICZwbGFuZS0+ZnBzX2luZm87CkBAIC03Niw3ICs2Niw3IEBAIHZvaWQgc3RpX3Bs YW5lX3VwZGF0ZV9mcHMoc3RydWN0IHN0aV9wbGFuZSAqcGxhbmUsCiAJCXJldHVybjsKCiAJZnBz LT5jdXJyX2ZyYW1lX2NvdW50ZXIrKzsKLQltc19zaW5jZV9sYXN0ID0gc3RpX3BsYW5lX3RpbWVz cGVjX21zX2RpZmYobm93LCBmcHMtPmxhc3RfdGltZXN0YW1wKTsKKwltc19zaW5jZV9sYXN0ID0g a3RpbWVfdG9fbXMoa3RpbWVfc3ViKG5vdywgZnBzLT5sYXN0X3RpbWVzdGFtcCkpOwogCW51bV9m cmFtZXMgPSBmcHMtPmN1cnJfZnJhbWVfY291bnRlciAtIGZwcy0+bGFzdF9mcmFtZV9jb3VudGVy OwoKIAlpZiAobnVtX2ZyYW1lcyA8PSAwICB8fCBtc19zaW5jZV9sYXN0IDwgU1RJX0ZQU19JTlRF UlZBTF9NUykKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3BsYW5lLmggYi9k cml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9wbGFuZS5oCmluZGV4IGM1MGEzYjkuLjBhNjRlYjAgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3BsYW5lLmgKKysrIGIvZHJpdmVycy9n cHUvZHJtL3N0aS9zdGlfcGxhbmUuaApAQCAtNTcsNyArNTcsNyBAQCBzdHJ1Y3Qgc3RpX2Zwc19p bmZvIHsKIAl1bnNpZ25lZCBpbnQgbGFzdF9mcmFtZV9jb3VudGVyOwogCXVuc2lnbmVkIGludCBj dXJyX2ZpZWxkX2NvdW50ZXI7CiAJdW5zaWduZWQgaW50IGxhc3RfZmllbGRfY291bnRlcjsKLQlz dHJ1Y3QgdGltZXNwZWMgbGFzdF90aW1lc3RhbXA7CisJa3RpbWVfdAkgICAgIGxhc3RfdGltZXN0 YW1wOwogCWNoYXIgZnBzX3N0cltGUFNfTEVOR1RIXTsKIAljaGFyIGZpcHNfc3RyW0ZQU19MRU5H VEhdOwogfTsKLS0KMi44LjAucmMzLjIyNi5nMzlkNDAyMAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWTIwMzggbWFpbGluZyBsaXN0ClkyMDM4QGxpc3Rz LmxpbmFyby5vcmcKaHR0cHM6Ly9saXN0cy5saW5hcm8ub3JnL21haWxtYW4vbGlzdGluZm8veTIw MzgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933921AbcDMLpD (ORCPT ); Wed, 13 Apr 2016 07:45:03 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:34318 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933331AbcDMLo7 (ORCPT ); Wed, 13 Apr 2016 07:44:59 -0400 Date: Wed, 13 Apr 2016 02:28:02 -0700 From: Tina Ruchandani To: Arnd Bergmann Cc: y2038@lists.linaro.org, Benjamin Gaignard , Vincent Abriou , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/sti: Use 64-bit timestamps Message-ID: <20160413092802.GA99759@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'struct timespec' uses a 32-bit field for seconds, which will overflow in year 2038 and beyond. This patch is part of a larger attempt to remove instances of timeval, timespec and time_t, all of which suffer from the y2038 issue, from the kernel. Signed-off-by: Tina Ruchandani --- drivers/gpu/drm/sti/sti_plane.c | 16 +++------------- drivers/gpu/drm/sti/sti_plane.h | 2 +- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c index f10c98d..3b46899 100644 --- a/drivers/gpu/drm/sti/sti_plane.c +++ b/drivers/gpu/drm/sti/sti_plane.c @@ -45,25 +45,15 @@ const char *sti_plane_to_str(struct sti_plane *plane) #define STI_FPS_INTERVAL_MS 3000 -static int sti_plane_timespec_ms_diff(struct timespec lhs, struct timespec rhs) -{ - struct timespec tmp_ts = timespec_sub(lhs, rhs); - u64 tmp_ns = (u64)timespec_to_ns(&tmp_ts); - - do_div(tmp_ns, NSEC_PER_MSEC); - - return (u32)tmp_ns; -} - void sti_plane_update_fps(struct sti_plane *plane, bool new_frame, bool new_field) { - struct timespec now; + ktime_t now; struct sti_fps_info *fps; int fpks, fipks, ms_since_last, num_frames, num_fields; - getrawmonotonic(&now); + now = ktime_get(); /* Compute number of frame updates */ fps = &plane->fps_info; @@ -76,7 +66,7 @@ void sti_plane_update_fps(struct sti_plane *plane, return; fps->curr_frame_counter++; - ms_since_last = sti_plane_timespec_ms_diff(now, fps->last_timestamp); + ms_since_last = ktime_to_ms(ktime_sub(now, fps->last_timestamp)); num_frames = fps->curr_frame_counter - fps->last_frame_counter; if (num_frames <= 0 || ms_since_last < STI_FPS_INTERVAL_MS) diff --git a/drivers/gpu/drm/sti/sti_plane.h b/drivers/gpu/drm/sti/sti_plane.h index c50a3b9..0a64eb0 100644 --- a/drivers/gpu/drm/sti/sti_plane.h +++ b/drivers/gpu/drm/sti/sti_plane.h @@ -57,7 +57,7 @@ struct sti_fps_info { unsigned int last_frame_counter; unsigned int curr_field_counter; unsigned int last_field_counter; - struct timespec last_timestamp; + ktime_t last_timestamp; char fps_str[FPS_LENGTH]; char fips_str[FPS_LENGTH]; }; -- 2.8.0.rc3.226.g39d4020