From: Ingo Molnar <mingo@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: peterz@infradead.org, Ingo Molnar <mingo@redhat.com>,
"open list:SCHEDULER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline
Date: Wed, 13 Apr 2016 11:41:59 +0200 [thread overview]
Message-ID: <20160413094158.GA6430@gmail.com> (raw)
In-Reply-To: <1459541050-13654-1-git-send-email-daniel.lezcano@linaro.org>
* Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> The local_clock/cpu_clock functions were changed to prevent a double
> identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK
> is set. That resulted in one line functions.
>
> As these functions are in all the cases one line functions and in the
> hot path, it is useful to specify them as static inline in order to
> give a strong hint to the compiler.
>
> After verification, it appears the compiler does not inline them
> without this hint. Change those functions to static inline.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> include/linux/sched.h | 32 ++++++++++++++++++++++++++++++--
> kernel/sched/clock.c | 41 -----------------------------------------
> 2 files changed, 30 insertions(+), 43 deletions(-)
Hm, this does not seem to apply to v4.6-rc3 cleanly.
Thanks,
Ingo
next prev parent reply other threads:[~2016-04-13 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 20:04 [PATCH] sched/clock: Make local_clock/cpu_clock inline Daniel Lezcano
2016-04-13 9:41 ` Ingo Molnar [this message]
2016-04-13 9:46 ` Daniel Lezcano
2016-04-13 9:51 ` Ingo Molnar
2016-04-13 10:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413094158.GA6430@gmail.com \
--to=mingo@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.