From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id E3CCEE00E26; Wed, 13 Apr 2016 07:13:56 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FAKE_REPLY_C, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 1.5 FAKE_REPLY_C FAKE_REPLY_C Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id DD4B0E0077E for ; Wed, 13 Apr 2016 07:13:44 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 13 Apr 2016 07:13:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,479,1455004800"; d="scan'208";a="685609359" Received: from linux.intel.com ([10.23.219.25]) by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2016 07:13:41 -0700 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id 417356A4006 for ; Wed, 13 Apr 2016 08:01:20 -0700 (PDT) Date: Wed, 13 Apr 2016 14:53:50 +0300 From: Ed Bartosh To: toaster@yoctoproject.org Message-ID: <20160413115350.GA26809@linux.intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: Error with git+ssh repositories in Toaster X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 14:13:56 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Stephan, I wasn't able to reproduce the issue on master and toaster-next. Can you give us some details regarding 'strange behaviour' of toaster and bitbake you're seeing? > Dear Maintainer > > We are using toaster sucessfully (git://git.yoctoproject.org/poky.git: > b1f23d1254682866236bfaeb843c0d8aa332efc2) > > I am facing a strange behaviour of toaster/bitbake when cloning git+ssh > repositories. > The source of the problem seems to be the "+" in the cloned foldername. > > e.g. _git+ssh___bytesatwork.ch_repository > > I suggest replacing the "+" with a "_" in the regex of > localhostbecontroller.py > > With this fix, toaster works as suspected. > > > diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > index b5cf559..2328edd 100644 > --- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > +++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > @@ -183,7 +183,7 @@ class > LocalhostBEController(BuildEnvironmentController): > def getGitCloneDirectory(self, url, branch): > """Construct unique clone directory name out of url and branch.""" > if branch != "HEAD": > - return "_toaster_clones/_%s_%s" % (re.sub('[:/@%]', '_', url), branch) > + return "_toaster_clones/_%s_%s" % (re.sub('[:/@+%]', '_', url), branch) > > # word of attention; this is a localhost-specific issue; only on the localhost we expect to have "HEAD" releases > # which _ALWAYS_ means the current poky checkout > > Best regards > > Stephan Dünner -- Regards, Ed