From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kurz <gkurz@linux.vnet.ibm.com>,
Jason Wang <jasowang@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH RFC 1/2] tun: don't require serialization lock on tx
Date: Wed, 13 Apr 2016 16:54:34 +0300 [thread overview]
Message-ID: <20160413165240-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1460554028.10638.18.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Apr 13, 2016 at 06:27:08AM -0700, Eric Dumazet wrote:
> I. On Wed, 2016-04-13 at 15:57 +0300, Michael S. Tsirkin wrote:
>
> > Fine, but what's the AF_PACKET duplication that Herbert Xu
> > reported with NETIF_F_LLTX? Does anyone remember?
>
> Really a lot of virtual drivers use NETIF_F_LLTX these days.
>
> Duplication is more likely to happen with a qdisc, when a packet is
> requeued if a driver returns NETDEV_TX_BUSY
OK, now I understand what the duplication is about.
What about NETDEV_TX_LOCKED? Looks like it might have
the same effect?
This might be worth documenting in include/linux/netdevice.h,
might it not?
--
MST
next prev parent reply other threads:[~2016-04-13 13:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 9:04 [PATCH RFC 0/2] tun: lockless xmit Paolo Abeni
2016-04-13 9:04 ` [PATCH RFC 1/2] tun: don't require serialization lock on tx Paolo Abeni
2016-04-13 9:41 ` Michael S. Tsirkin
2016-04-13 9:48 ` Hannes Frederic Sowa
2016-04-13 12:57 ` Michael S. Tsirkin
2016-04-13 13:27 ` Eric Dumazet
2016-04-13 13:54 ` Michael S. Tsirkin [this message]
2016-04-13 14:39 ` Eric Dumazet
2016-04-13 12:52 ` Eric Dumazet
2016-04-13 14:26 ` Sergei Shtylyov
2016-04-14 6:50 ` Jason Wang
2016-04-14 10:27 ` Hannes Frederic Sowa
2016-04-13 9:04 ` [PATCH RFC 2/2] tun: don't set a default qdisc Paolo Abeni
2016-04-13 10:26 ` Michael S. Tsirkin
2016-04-13 15:22 ` David Miller
2016-04-14 6:49 ` Jason Wang
2016-04-14 9:05 ` Michael S. Tsirkin
2016-04-14 9:07 ` Jason Wang
2016-04-14 9:10 ` Michael S. Tsirkin
2016-04-14 9:21 ` Jason Wang
2016-04-14 10:01 ` Michael S. Tsirkin
2016-04-14 10:09 ` Hannes Frederic Sowa
2016-04-13 11:08 ` [PATCH RFC 0/2] tun: lockless xmit Michael S. Tsirkin
2016-04-13 12:50 ` Eric Dumazet
2016-04-13 12:56 ` Michael S. Tsirkin
2016-04-13 13:09 ` Eric Dumazet
2016-04-13 13:17 ` Michael S. Tsirkin
2016-04-13 13:43 ` Eric Dumazet
2016-04-13 16:42 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413165240-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.