From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Glauber Subject: Re: [PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Date: Thu, 14 Apr 2016 10:05:11 +0200 Message-ID: <20160414080511.GB2532@hardcore> References: <5667768441feb526fbf1c3cd8768827393f9bfce.1460387640.git.jglauber@cavium.com> <20160413084521.GE1563@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-bl2on0086.outbound.protection.outlook.com ([65.55.169.86]:23872 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753086AbcDNIF2 (ORCPT ); Thu, 14 Apr 2016 04:05:28 -0400 Content-Disposition: inline In-Reply-To: <20160413084521.GE1563@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, David Daney On Wed, Apr 13, 2016 at 10:45:21AM +0200, Wolfram Sang wrote: > On Mon, Apr 11, 2016 at 05:28:35PM +0200, Jan Glauber wrote: > > Add helper functions for control, data and status register access. > > > > Signed-off-by: Jan Glauber > > Same as patch 3. > Updated commit message: i2c: octeon: Introduce helper functions for register access Add helper functions for control, data and status register access. This simplifies the code and makes the purpose of the register access clearer. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754338AbcDNITu (ORCPT ); Thu, 14 Apr 2016 04:19:50 -0400 Received: from mail-bn1bon0090.outbound.protection.outlook.com ([157.56.111.90]:62251 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752599AbcDNITo (ORCPT ); Thu, 14 Apr 2016 04:19:44 -0400 Authentication-Results: the-dreams.de; dkim=none (message not signed) header.d=none;the-dreams.de; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 14 Apr 2016 10:05:11 +0200 From: Jan Glauber To: Wolfram Sang CC: , , David Daney Subject: Re: [PATCH v6 04/19] i2c: octeon: Introduce helper functions for register access Message-ID: <20160414080511.GB2532@hardcore> References: <5667768441feb526fbf1c3cd8768827393f9bfce.1460387640.git.jglauber@cavium.com> <20160413084521.GE1563@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160413084521.GE1563@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [109.193.45.40] X-ClientProxiedBy: AM3PR08CA0079.eurprd08.prod.outlook.com (10.163.23.175) To BN3PR07MB2579.namprd07.prod.outlook.com (10.167.5.7) X-MS-Office365-Filtering-Correlation-Id: 7621e440-664e-42cc-d45a-08d3643b88ab X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2579;2:PY++vuCM88Pv5LjK7V0wGKbvF3OxGKYM20Z+6UK3mh7bIzJeLM9WP1qLIXQfonQaSbgx74Kf+AHIlcRgg9cWaWQopFtBD5HOo/cHpUluwfnO9qtcuCPrRu+D2sMXBzrmgHjM9r1g1ha4v2cwPZM8yCVp8uGiX8qdtG+7oy7SK0HJbcx3o3UIntKMFdnxUw5Y;3:wegBZ0c/Xcw4Ou2YyXIs/7bMKKxwP5nMy38dEfboHjmlbrsDYDsFfcNwVdNN+etHd09IEVwBMSKFwQZm4QjkMg73qtKgfoz2Uj7eU5RmfDh0BtNWoM/acxjeOGqtEfhJ;25:nASZk5Fy/JQdkVzgF5CgozPymXXBlrRIN2mU32pJsBlSvELUHK6x8bM3vXKs4d3UggBNtIi+Ryk83JFzpapzarQX32XEHYmF5LD/U2uT4OlJDQ3/dyWtLPOEeOxvUw7++y6bEVQ4yAxc8RHxjL7RAP67umESfXNeuicieVoMRy/8mmBr18SBOD19Ed1Z8yRmsa60fwmqn8BSnVxq3prntj4sXQODmop92EFoRsgnMQlBBVDLl3Om3JY52q78nlwCqf3pkaL4sQxPKFdLGzVz8ao8oAsUcWaPH33g8KMw0x4+lQtDh/uDLFEufMJ9v8TdkqD8NV2U6Zc5DcnrQuMmxw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2579; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2579;20:R85W3RxLHDzm+JmVNrfTveR26/qqWqDpeO0gq8jNa6dCeVeFDvUdNjwdUGD32SHjOIJvPXwp6vdW7MXpr1Z+76YjcuqzpM8MF4HxeqwoH8hSumsbs26JBgGboQA3kQTy4c2UO96+n5CQRmIWMKwP1VcOAR/7+BVRrkFrxvk7Voz82de1mo1860isvCqrhYdRuyeHcM8UidIJzcPxhOUv3Ahbdj1uBHEx2/eYRsd7kNGB/hrbjYxx9AD+MCtAUmXjnevWa+qtxksqzz7cBCGfwYme/MaObHb4u5qEbXyRwTE3VemPUkSFKioF4j+gHWRvp9TjiEQ6ZrmBvShvpyjDUmKVcPqxHe9pe6IP/V30A6isVH7S6mRnpWX7YAhtTsK25WzUBxlAK155vk2PUODKvJXGhScTBinvWOcwj0j4n0TEoCCnSgtuggqq7A5MQlQCEl3p+z6rToTN155JRR+FtvLahmlm16k7CaWfZ1/j7Fxsj/NnlYaQXPe6FDi5OUimhoOV8vW6FLZJZTZJ63XHwmFMChf1V8weX3u1avvYtoCbgTwZJxfdyyiJpkez3Auh2BrGGriS5DLyZLDUVoOwvTbeK+WA4wAZcACvArZifb4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN3PR07MB2579;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2579; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2579;4:ecFHsaOGMMazkg2Oh1xHh5FitalPzNedKUafIuW4BkN/JL1kns8EM2oe8KKz7OwHuqQ/+zj0sU6sX5CDTB3HUAocbMEmVXGVgzAyODnQkxDcsoiKAxNq0zY2MhI53KMou0VXqktQfPchlTjGcMHkSMHXRi4f4re+idvt3Qs52UyjsNBmNaIOJYYxWGlG/OskxD1Loc+lYDwhYUb9GZKb2cxT7MlzAXOCg1zt8LV62VP39/uS+niZggafr+vukN32/00CkMmvnmU19FIi+ULrbcdIYyWWUNTIvRPr2GObBvMmjGLqdhMDL1TBxixh/9ZMC6rdqVo/LNPChcYLaV1J7PsJqABkfZ07jTXU2W3u2H0gYraczLjq8fJYQnRNRvHy X-Forefront-PRVS: 0912297777 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(33716001)(77096005)(2950100001)(19580405001)(3846002)(92566002)(1096002)(5008740100001)(6116002)(2906002)(1076002)(47776003)(23726003)(33656002)(66066001)(4326007)(586003)(19580395003)(50466002)(76176999)(50986999)(54356999)(4001430100002)(4001350100001)(189998001)(86362001)(5004730100002)(46406003)(110136002)(107886002)(97756001)(9686002)(81166005)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2579;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR07MB2579;23:af/arlA1vU5YRHsXzzKvCFRMxZJX/3A4pYThpgzIP?= =?us-ascii?Q?LRg3pMo7mKMAvBItr7sdQ2/uSGznZTCwWY1s094ULiNhwIoKqzoq6zUwvRGT?= =?us-ascii?Q?SLyJNIAtyjR9ez7I6c3cDHoarnfDWDxFO/qCPZA+bXUMZFn6H0aoKWy5QAWC?= =?us-ascii?Q?fWDLu+vaLQsoQnIi2BK/UEdGVMgdyp6+MBjwdK+eDj1XKwA4a3pNyRdBwzYU?= =?us-ascii?Q?yxLvLht/EOEkSzLBWANZDA9v8uo1QXDWRaG8qxdN5dWX6Pj/5xtSkWANSIYm?= =?us-ascii?Q?wTiwqI13Mue8s7Fc74tmbe6Jdz5mL5ojfCl5ZF5RGHJdRpkZJMDuGnw8qW/S?= =?us-ascii?Q?PxoH5MWA+ZC106t5oRtoNOJgOyOOnlf+CmDmzcT3uLXdfgveO/lxosP0vSYH?= =?us-ascii?Q?Nx+6MFRMMejkDYPrr6u3biJcObimpWNwOZjDnusCjXSaU3IxpzTKz4CIYKjz?= =?us-ascii?Q?38BIQJq5exOKXCYaHPQyiS2vcUxgIvdJEtIxD53yJmFbWVeyZ8IxyPej+Rm/?= =?us-ascii?Q?HfCpAZYIaavB9J8fuwM8Kp2duW2bw8Fs6iRvhEMglTt4vCA+SvPHyex9SfNs?= =?us-ascii?Q?k8mx2CbbU9j+nNkuK6kRsj6zsPu5jRHp2h/G6S6KX8KEOb6M0bQWnARB0yYM?= =?us-ascii?Q?+pZXLGfQunQ5QMQYjrD3uiPB9ZDoo2ga6B3UghL91xGm2LMeHt0bWeeWiifS?= =?us-ascii?Q?vaZ9zn0cqwwKM+JGaMNOklYicz5H8OICni77QnGkM/OPZ0aDnJm4Bwh953+t?= =?us-ascii?Q?BKHdFBmZwwEhwrSHNOs+N60Zs7qmW5L4nd+447fJyjcS/rzil/8OrZIuIggU?= =?us-ascii?Q?HrqagKvoG0pw1z2eP/sHP/TzZH+QfWXfcZ/jb55NfImcYH/64vibqqAnyjkZ?= =?us-ascii?Q?+e6NKl4EGlltL8+pA6YI8yVRFpyAt/nu15JSLCgA1eL7oqWWNyt5R4eSkARA?= =?us-ascii?Q?iiu77NknS2aPutuIfrbXe+Zn7mk+CpVkXvaRUt2pXmOIPrcny1iVjCLCsbAB?= =?us-ascii?Q?kIE5k6LMLdVxj+g+n9L/m+d?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2579;5:YWIN3q8XPbEIOe+ZAG34ftspZ8rsqDRoUI0qMTps87Il2lIvrx3kTHTas0eG+KcIxQuLqgCcYnyCsaxee2xwHUG1a7n2qTK4mtoU7jVVJ0Q0XPwX9RaMD+857kDvvXAXWi/ccR7E+hQDBzwE2gbcFg==;24:bY+2h6G+/7Tsik9bU91zvKMfMcHLLBrI7CSrRW/Y0tIJ2u67OQ5dX8Lo8AZKTqJKApM8uuTg48oG/1390VozhXiDhjA8AIQITyKfyv8KRIo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2016 08:05:23.9744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2579 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2016 at 10:45:21AM +0200, Wolfram Sang wrote: > On Mon, Apr 11, 2016 at 05:28:35PM +0200, Jan Glauber wrote: > > Add helper functions for control, data and status register access. > > > > Signed-off-by: Jan Glauber > > Same as patch 3. > Updated commit message: i2c: octeon: Introduce helper functions for register access Add helper functions for control, data and status register access. This simplifies the code and makes the purpose of the register access clearer.