From: Pavel Machek <pavel@ucw.cz>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org,
"Sameer Nanda" <snanda@chromium.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbò" <enric.balletbo@collabora.co.uk>,
"Vic Yang" <victoryang@chromium.org>,
"Stephen Boyd" <sboyd@codeaurora.org>,
"Vincent Palatin" <vpalatin@chromium.org>,
"Randall Spangler" <rspangler@chromium.org>,
"Todd Broch" <tbroch@chromium.org>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Shawn Nematbakhsh" <shawnn@chromium.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
linux-pm@vger.kernel.org, "David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver
Date: Thu, 14 Apr 2016 11:35:57 +0200 [thread overview]
Message-ID: <20160414093557.GA26596@amd> (raw)
In-Reply-To: <1457970301-24616-6-git-send-email-tomeu.vizoso@collabora.com>
> +#define CHARGER_DIR_NAME "CROS_USB_PD_CHARGER%d"
> +#define CHARGER_DIR_NAME_LENGTH sizeof(CHARGER_DIR_NAME)
> +
> +#define MANUFACTURER_MODEL_LENGTH 32
> +
> +struct port_data {
> + int port_number;
> + char name[CHARGER_DIR_NAME_LENGTH];
That's not really correct, right? If we ever have more than 99 such
chargers...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-04-14 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 15:44 [PATCH v5 0/6] EC-based USB Power Delivery support for Chrome machines Tomeu Vizoso
2016-03-14 15:44 ` [PATCH v5 1/6] mfd: cros_ec: Add MKBP event support Tomeu Vizoso
2016-03-14 15:44 ` [PATCH v5 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Tomeu Vizoso
2016-03-14 17:24 ` Benson Leung
2016-03-14 15:44 ` [PATCH v5 3/6] mfd: cros_ec: Add cros_ec_get_host_event Tomeu Vizoso
2016-03-14 19:23 ` Benson Leung
2016-03-14 15:44 ` [PATCH v5 4/6] mfd: cros_ec: Add more definitions for PD commands Tomeu Vizoso
2016-03-14 15:45 ` [PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver Tomeu Vizoso
2016-04-14 9:35 ` Pavel Machek [this message]
2016-03-14 15:45 ` [PATCH v5 6/6] platform/chrome: Register USB PD charger device Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414093557.GA26596@amd \
--to=pavel@ucw.cz \
--cc=bleung@chromium.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rspangler@chromium.org \
--cc=sboyd@codeaurora.org \
--cc=shawnn@chromium.org \
--cc=snanda@chromium.org \
--cc=sre@kernel.org \
--cc=tbroch@chromium.org \
--cc=tomeu.vizoso@collabora.com \
--cc=victoryang@chromium.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.