All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: jacob.shin@amd.com
Cc: linux-pm@vger.kernel.org
Subject: re: cpufreq: AMD "frequency sensitivity feedback" powersave bias for ondemand governor
Date: Thu, 14 Apr 2016 14:03:27 +0300	[thread overview]
Message-ID: <20160414110327.GA24237@mwanda> (raw)

Hello Jacob Shin,

The patch 9c5320c8ea8b: "cpufreq: AMD "frequency sensitivity
feedback" powersave bias for ondemand governor" from Apr 4, 2013,
leads to the following static checker warning:

	drivers/cpufreq/amd_freq_sensitivity.c:98 amd_powersave_bias_target()
	error: uninitialized symbol 'index'.

drivers/cpufreq/amd_freq_sensitivity.c
    83          /* this workload is not CPU bound, so choose a lower freq */
    84          if (sensitivity < od_tuners->powersave_bias) {
    85                  if (data->freq_prev == policy->cur)
    86                          freq_next = policy->cur;
    87  
    88                  if (freq_next > policy->cur)
    89                          freq_next = policy->cur;
    90                  else if (freq_next < policy->cur)
    91                          freq_next = policy->min;
    92                  else {
    93                          unsigned int index;
    94  
    95                          cpufreq_frequency_table_target(policy,
    96                                  od_info->freq_table, policy->cur - 1,
    97                                  CPUFREQ_RELATION_H, &index);

If cpufreq_frequency_table_target() return -EINVAL the index isn't set.

    98                          freq_next = od_info->freq_table[index].frequency;
    99                  }


regards,
dan carpenter

                 reply	other threads:[~2016-04-14 11:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414110327.GA24237@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jacob.shin@amd.com \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.