From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use fw_domains_put_with_fifo() on HSW
Date: Thu, 14 Apr 2016 15:28:05 +0300 [thread overview]
Message-ID: <20160414122805.GK4329@intel.com> (raw)
In-Reply-To: <87ziswmms9.fsf@gaia.fi.intel.com>
On Thu, Apr 14, 2016 at 02:51:02PM +0300, Mika Kuoppala wrote:
> ville.syrjala@linux.intel.com writes:
>
> > [ text/plain ]
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > HSW still has the wake FIFO, so let's check it.
> >
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Cc: Deepak S <deepak.s@linux.intel.com>
> > Fixes: 05a2fb157e44 ("drm/i915: Consolidate forcewake code")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Pushed to dinq. Thanks for the review.
>
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index 4db21ef36b16..4f1dfe616856 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -1265,7 +1265,11 @@ static void intel_uncore_fw_domains_init(struct drm_device *dev)
> > } else if (IS_HASWELL(dev) || IS_BROADWELL(dev)) {
> > dev_priv->uncore.funcs.force_wake_get =
> > fw_domains_get_with_thread_status;
> > - dev_priv->uncore.funcs.force_wake_put = fw_domains_put;
> > + if (IS_HASWELL(dev))
> > + dev_priv->uncore.funcs.force_wake_put =
> > + fw_domains_put_with_fifo;
> > + else
> > + dev_priv->uncore.funcs.force_wake_put = fw_domains_put;
> > fw_domain_init(dev_priv, FW_DOMAIN_ID_RENDER,
> > FORCEWAKE_MT, FORCEWAKE_ACK_HSW);
> > } else if (IS_IVYBRIDGE(dev)) {
> > --
> > 2.7.4
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-04-14 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 11:39 [PATCH] drm/i915: Use fw_domains_put_with_fifo() on HSW ville.syrjala
2016-04-14 11:48 ` Ville Syrjälä
2016-04-14 11:51 ` Mika Kuoppala
2016-04-14 12:18 ` Chris Wilson
2016-04-14 12:28 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414122805.GK4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.