From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 2/2] drm/amd/powerplay/hwmgr: don't add invalid voltage Date: Thu, 14 Apr 2016 17:34:12 -0700 Message-ID: <20160415003412.GD3312@joana> References: <1460664628-14623-1-git-send-email-kuehner.moritz@gmail.com> <1460664628-14623-3-git-send-email-kuehner.moritz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BB0A6E45D for ; Fri, 15 Apr 2016 00:34:15 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id er2so21136531pad.3 for ; Thu, 14 Apr 2016 17:34:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1460664628-14623-3-git-send-email-kuehner.moritz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Moritz =?iso-8859-1?Q?K=FChner?= Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTW9yaXR6LAoKMjAxNi0wNC0xNCBNb3JpdHogS8O8aG5lciA8a3VlaG5lci5tb3JpdHpAZ21h aWwuY29tPjoKCj4gaWYgYXRvbWN0cmxfZ2V0X3ZvbHRhZ2VfZXZ2X29uX3NjbGsgcmV0dXJucyBu b24gemVybyAoZmFpbCkgaW4gdGhlIGV4cGFuc2lvbgo+IG9mIHRoZSBQUF9BU1NFUlRfV0lUSF9D T0RFIG1hY3JvIHRoZSBjb250aW51ZSB3aWxsIGFjdHVhbGx5IGRvIG5vdGhpbmcKPiAoVGhlIG1h Y3JvIHVzZXMgYSBkbyAuLi4gd2hpbGUoMCkgYXMgc2NvcGUsIHdoaWNoIGVhdHMgdGhlIGNvbnRp bnVlKS4KPiBCYXNlZCBvbiB0aGUgY29kZSBJIGRvbid0IHRoaW5rIHRoaXMgd2FzIHRoZSBpbnRl bnQuCj4gVW5mb3J0dW5hdGVseSBmaXhpbmcgdGhpcyByZXF1aXJlcyByZXdyaXRpbmcgdGhlIGNv bnRyb2wgZmxvdyBhbmQKPiByZW1vdmluZyB0aGUgbWFjcm9zLgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL3Bvd2VycGxheS9od21nci90b25nYV9od21nci5jIHwgNTQgKysrKysrKysrKysr Ky0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDI0IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9o d21nci90b25nYV9od21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaHdtZ3Iv dG9uZ2FfaHdtZ3IuYwo+IGluZGV4IDUwYWZiMDIuLjlhNWQxMGEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaHdtZ3IvdG9uZ2FfaHdtZ3IuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3RvbmdhX2h3bWdyLmMKPiBAQCAtNDI5 LDE5ICs0MjksMjIgQEAgaW50IHRvbmdhX2dldF9ldnZfdm9sdGFnZShzdHJ1Y3QgcHBfaHdtZ3Ig Kmh3bWdyKQo+ICAJCQkJCQl9Cj4gIAkJCQkJfQo+ICAJCQkJfQo+IC0JCQkJUFBfQVNTRVJUX1dJ VEhfQ09ERSgwID09IGF0b21jdHJsX2dldF92b2x0YWdlX2V2dl9vbl9zY2xrCj4gKwkJCQlpZiAo MCA9PSBhdG9tY3RybF9nZXRfdm9sdGFnZV9ldnZfb25fc2Nsawo+ICAJCQkJCQkoaHdtZ3IsIFZP TFRBR0VfVFlQRV9WRERHRlgsIHNjbGssCj4gLQkJCQkJCSB2aXJ0dWFsX3ZvbHRhZ2VfaWQsICZ2 ZGRnZngpLAo+IC0JCQkJCQkiRXJyb3IgcmV0cmlldmluZyBFVlYgdm9sdGFnZSB2YWx1ZSEiLCBj b250aW51ZSk7Cj4gLQo+IC0JCQkJLyogbmVlZCB0byBtYWtlIHN1cmUgdmRkZ2Z4IGlzIGxlc3Mg dGhhbiAydiBvciBlbHNlLCBpdCBjb3VsZCBidXJuIHRoZSBBU0lDLiAqLwo+IC0JCQkJUFBfQVNT RVJUX1dJVEhfQ09ERSgodmRkZ2Z4IDwgMjAwMCAmJiB2ZGRnZnggIT0gMCksICJJbnZhbGlkIFZE REdGWCB2YWx1ZSEiLCByZXR1cm4gLTEpOwo+IC0KPiAtCQkJCS8qIHRoZSB2b2x0YWdlIHNob3Vs ZCBub3QgYmUgemVybyBub3IgZXF1YWwgdG8gbGVha2FnZSBJRCAqLwo+IC0JCQkJaWYgKHZkZGdm eCAhPSAwICYmIHZkZGdmeCAhPSB2aXJ0dWFsX3ZvbHRhZ2VfaWQpIHsKPiAtCQkJCQlkYXRhLT52 ZGRjZ2Z4X2xlYWthZ2UuYWN0dWFsX3ZvbHRhZ2VbZGF0YS0+dmRkY2dmeF9sZWFrYWdlLmNvdW50 XSA9IHZkZGdmeDsKPiAtCQkJCQlkYXRhLT52ZGRjZ2Z4X2xlYWthZ2UubGVha2FnZV9pZFtkYXRh LT52ZGRjZ2Z4X2xlYWthZ2UuY291bnRdID0gdmlydHVhbF92b2x0YWdlX2lkOwo+IC0JCQkJCWRh dGEtPnZkZGNnZnhfbGVha2FnZS5jb3VudCsrOwo+ICsJCQkJCQkgdmlydHVhbF92b2x0YWdlX2lk LCAmdmRkZ2Z4KSkgewo+ICsJCQkJCS8qIG5lZWQgdG8gbWFrZSBzdXJlIHZkZGdmeCBpcyBsZXNz IHRoYW4gMnYgb3IgZWxzZSwgaXQgY291bGQgYnVybiB0aGUgQVNJQy4gKi8KPiArCQkJCQlQUF9B U1NFUlRfV0lUSF9DT0RFKCh2ZGRnZnggPCAyMDAwICYmIHZkZGdmeCAhPSAwKSwgIkludmFsaWQg VkRER0ZYIHZhbHVlISIsIHJldHVybiAtMSk7Cj4gKwo+ICsJCQkJCS8qIHRoZSB2b2x0YWdlIHNo b3VsZCBub3QgYmUgemVybyBub3IgZXF1YWwgdG8gbGVha2FnZSBJRCAqLwo+ICsJCQkJCWlmICh2 ZGRnZnggIT0gMCAmJiB2ZGRnZnggIT0gdmlydHVhbF92b2x0YWdlX2lkKSB7Cj4gKwkJCQkJCWRh dGEtPnZkZGNnZnhfbGVha2FnZS5hY3R1YWxfdm9sdGFnZVtkYXRhLT52ZGRjZ2Z4X2xlYWthZ2Uu Y291bnRdID0gdmRkZ2Z4Owo+ICsJCQkJCQlkYXRhLT52ZGRjZ2Z4X2xlYWthZ2UubGVha2FnZV9p ZFtkYXRhLT52ZGRjZ2Z4X2xlYWthZ2UuY291bnRdID0gdmlydHVhbF92b2x0YWdlX2lkOwo+ICsJ CQkJCQlkYXRhLT52ZGRjZ2Z4X2xlYWthZ2UuY291bnQrKzsKPiArCQkJCQl9Cj4gKwkJCQl9Cj4g KwkJCQllbHNlCj4gKwkJCQl7Cj4gKwkJCQkJcHJpbnRrKCIlc1xuIiwgIkVycm9yIHJldHJpZXZp bmcgRVZWIHZvbHRhZ2UgdmFsdWUhIik7CgpVc2UgRFJNX0VSUk9SIGhlcmUuIEFuZCBubyBuZWVk IHRvIGZvciAlcyBvbiB0aGlzIGZvcm1hdCBzdHJpbmcuIEkgdGhpbmsKeW91IHdhbnQgc29tZXRo aW5nIGxpa2UgdGhpczoKCglEUk1fRVJST1IoIkVycm9yIHJldHJpZXZpbmcgRVZWIHZvbHRhZ2Ug dmFsdWUhXG4iKTsKCj4gIAkJCQl9Cj4gIAkJCX0KPiAgCQl9IGVsc2Ugewo+IEBAIC00NDksMTkg KzQ1MiwyMiBAQCBpbnQgdG9uZ2FfZ2V0X2V2dl92b2x0YWdlKHN0cnVjdCBwcF9od21nciAqaHdt Z3IpCj4gIAkJCWlmICgwID09IHRvbmdhX2dldF9zY2xrX2Zvcl92b2x0YWdlX2V2dihod21nciwK PiAgCQkJCQkJcHB0YWJsZV9pbmZvLT52ZGRjX2xvb2t1cF90YWJsZSwKPiAgCQkJCQkJdmlydHVh bF92b2x0YWdlX2lkLCAmc2NsaykpIHsKPiAtCQkJCVBQX0FTU0VSVF9XSVRIX0NPREUoMCA9PSBh dG9tY3RybF9nZXRfdm9sdGFnZV9ldnZfb25fc2Nsawo+ICsJCQkJaWYgKDAgPT0gYXRvbWN0cmxf Z2V0X3ZvbHRhZ2VfZXZ2X29uX3NjbGsKPiAgCQkJCQkJKGh3bWdyLCBWT0xUQUdFX1RZUEVfVkRE Qywgc2NsaywKPiAtCQkJCQkJIHZpcnR1YWxfdm9sdGFnZV9pZCwgJnZkZGMpLAo+IC0JCQkJCQki RXJyb3IgcmV0cmlldmluZyBFVlYgdm9sdGFnZSB2YWx1ZSEiLCBjb250aW51ZSk7Cj4gLQo+IC0J CQkJLyogbmVlZCB0byBtYWtlIHN1cmUgdmRkYyBpcyBsZXNzIHRoYW4gMnYgb3IgZWxzZSwgaXQg Y291bGQgYnVybiB0aGUgQVNJQy4gKi8KPiAtCQkJCVBQX0FTU0VSVF9XSVRIX0NPREUodmRkYyA8 IDIwMDAsICJJbnZhbGlkIFZEREMgdmFsdWUhIiwgcmV0dXJuIC0xKTsKPiAtCj4gLQkJCQkvKiB0 aGUgdm9sdGFnZSBzaG91bGQgbm90IGJlIHplcm8gbm9yIGVxdWFsIHRvIGxlYWthZ2UgSUQgKi8K PiAtCQkJCWlmICh2ZGRjICE9IDAgJiYgdmRkYyAhPSB2aXJ0dWFsX3ZvbHRhZ2VfaWQpIHsKPiAt CQkJCQlkYXRhLT52ZGRjX2xlYWthZ2UuYWN0dWFsX3ZvbHRhZ2VbZGF0YS0+dmRkY19sZWFrYWdl LmNvdW50XSA9IHZkZGM7Cj4gLQkJCQkJZGF0YS0+dmRkY19sZWFrYWdlLmxlYWthZ2VfaWRbZGF0 YS0+dmRkY19sZWFrYWdlLmNvdW50XSA9IHZpcnR1YWxfdm9sdGFnZV9pZDsKPiAtCQkJCQlkYXRh LT52ZGRjX2xlYWthZ2UuY291bnQrKzsKPiArCQkJCQkJIHZpcnR1YWxfdm9sdGFnZV9pZCwgJnZk ZGMpKSB7Cj4gKwkJCQkJLyogbmVlZCB0byBtYWtlIHN1cmUgdmRkYyBpcyBsZXNzIHRoYW4gMnYg b3IgZWxzZSwgaXQgY291bGQgYnVybiB0aGUgQVNJQy4gKi8KPiArCQkJCQlQUF9BU1NFUlRfV0lU SF9DT0RFKHZkZGMgPCAyMDAwLCAiSW52YWxpZCBWRERDIHZhbHVlISIsIHJldHVybiAtMSk7Cj4g Kwo+ICsJCQkJCS8qIHRoZSB2b2x0YWdlIHNob3VsZCBub3QgYmUgemVybyBub3IgZXF1YWwgdG8g bGVha2FnZSBJRCAqLwo+ICsJCQkJCWlmICh2ZGRjICE9IDAgJiYgdmRkYyAhPSB2aXJ0dWFsX3Zv bHRhZ2VfaWQpIHsKPiArCQkJCQkJZGF0YS0+dmRkY19sZWFrYWdlLmFjdHVhbF92b2x0YWdlW2Rh dGEtPnZkZGNfbGVha2FnZS5jb3VudF0gPSB2ZGRjOwo+ICsJCQkJCQlkYXRhLT52ZGRjX2xlYWth Z2UubGVha2FnZV9pZFtkYXRhLT52ZGRjX2xlYWthZ2UuY291bnRdID0gdmlydHVhbF92b2x0YWdl X2lkOwo+ICsJCQkJCQlkYXRhLT52ZGRjX2xlYWthZ2UuY291bnQrKzsKPiArCQkJCQl9Cj4gKwkJ CQl9Cj4gKwkJCQllbHNlCj4gKwkJCQl7Cj4gKwkJCQkJcHJpbnRrKCIlc1xuIiwgIkVycm9yIHJl dHJpZXZpbmcgRVZWIHZvbHRhZ2UgdmFsdWUhIik7CgpzYW1lIGhlcmUuCgoJR3VzdGF2bwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK