From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support
Date: Fri, 15 Apr 2016 08:41:07 +0300 [thread overview]
Message-ID: <20160415054107.GH2092@tarshish> (raw)
In-Reply-To: <CAJ+vNU3-Ht7mVUn+T6n1YmYMwxzAW7X-ryccCZw0U_uNiGv2=A@mail.gmail.com>
Hi Tim,
On Thu, Apr 14, 2016 at 07:39:40AM -0700, Tim Harvey wrote:
> On Thu, Apr 14, 2016 at 6:32 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Thu, Apr 14, 2016 at 06:19:09AM -0700, Tim Harvey wrote:
> >> The GW52xx/GW53xx/GW54xx have an on-board RS485 transceiver for half-duplex
> >> RS485 using uart1. The active-high TXEN is GPIO7__IO1 which we can configure
> >> as the rts-gpio as long as we specify it as active-low to invert the polarity
> >> managed by mctrl_gpio helpers. This allows for RS485 to be used from
> >> userspace by setting flags to SER_RS485_RTS_ON_SEND in the serial_rs485
> >> struct when using the TIOCGRS485 ioctl.
> >
> > Do you use http://article.gmane.org/gmane.linux.ports.arm.kernel/482641 for
> > that?
>
> No - that wasn't in my tree, but I will test it and respond to that thread.
I see that the MAX14840 transceiver has built-in Rx disable on Tx logic, so
you don't strictly need this patch. But since my patch changes the behaviour
when SER_RS485_RX_DURING_TX is not set, it would be nice if you give it a spin
to verify that it doesn't break you use case.
I think though that a SER_RS485_DISABLE_RX_ON_TX flag that inverts the logic
of SER_RS485_RX_DURING_TX would make much more sense, both on serial drivers
side, and on userspace. But that's history now since we can't break the ABI.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-04-15 5:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 13:19 [PATCH] ARM: dts: imx: ventana: add RS485 txen gpio support Tim Harvey
2016-04-14 13:32 ` Baruch Siach
2016-04-14 14:39 ` Tim Harvey
2016-04-15 5:41 ` Baruch Siach [this message]
2016-04-18 12:04 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2016-06-29 13:38 Tim Harvey
2016-06-29 13:38 ` Tim Harvey
2016-08-08 8:40 ` Shawn Guo
2016-08-08 8:40 ` Shawn Guo
2016-08-09 19:08 ` Tim Harvey
2016-08-09 19:08 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415054107.GH2092@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.