From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, david.vrabel@citrix.com,
jbeulich@suse.com
Subject: Re: [PATCH 0/3] adjust error return values for cpupool operations
Date: Fri, 15 Apr 2016 15:58:52 +0100 [thread overview]
Message-ID: <20160415145852.GA18652@citrix.com> (raw)
In-Reply-To: <1460732057-30032-1-git-send-email-jgross@suse.com>
On Fri, Apr 15, 2016 at 04:54:14PM +0200, Juergen Gross wrote:
> Some cpupool operations return the same error value for multiple
> situations. This makes it hard for the tools to react accordingly e.g.
> by issuing a suitable error message.
>
> Return appropriate error values and document them.
>
> Juergen Gross (3):
> xen: return different error values for cpupool operations
> libxc: adjust retry loop in xc_cpupool_removecpu()
> xen: Document XEN_SYSCTL_CPUPOOL_OP_* error codes
>
> tools/libxc/xc_cpupool.c | 6 ++----
> xen/common/cpupool.c | 10 +++++-----
> xen/common/schedule.c | 2 +-
> xen/include/public/sysctl.h | 36 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 44 insertions(+), 10 deletions(-)
>
In principle I agree we need better semantics and documentation of this
hypercall, and because this is new code so it's risk free, so:
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
I will leave this series for Ian to review.
> --
> 2.6.6
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-15 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 14:54 [PATCH 0/3] adjust error return values for cpupool operations Juergen Gross
2016-04-15 14:54 ` [PATCH 1/3] xen: return different error " Juergen Gross
2016-04-15 15:18 ` Ian Jackson
2016-04-15 15:25 ` Dario Faggioli
2016-04-20 11:23 ` Jan Beulich
2016-04-15 14:54 ` [PATCH 2/3] libxc: adjust retry loop in xc_cpupool_removecpu() Juergen Gross
2016-04-15 15:19 ` Ian Jackson
2016-04-15 15:26 ` Dario Faggioli
2016-04-15 16:07 ` Alan Robinson
2016-04-15 14:54 ` [PATCH 3/3] xen: Document XEN_SYSCTL_CPUPOOL_OP_* error codes Juergen Gross
2016-04-15 15:25 ` Ian Jackson
2016-04-15 16:02 ` Juergen Gross
2016-04-15 14:58 ` Wei Liu [this message]
2016-04-20 13:47 ` [PATCH 0/3] adjust error return values for cpupool operations Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415145852.GA18652@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.