From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences Date: Fri, 15 Apr 2016 11:29:34 -0700 Message-ID: <20160415182934.GB23954@joana> References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E68E6ECEA for ; Fri, 15 Apr 2016 18:29:36 +0000 (UTC) Received: by mail-pf0-f182.google.com with SMTP id c20so59177769pfc.1 for ; Fri, 15 Apr 2016 11:29:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: =?iso-8859-1?Q?St=E9phane?= Marchesin , Daniel Stone , Sean Paul , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , dri-devel , Linux Kernel Mailing List , Riley Andrews , m.chehab@samsung.com, Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , John Harrison , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org MjAxNi0wNC0xNSBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OgoKPiBPbiBGcmksIEFw ciAxNSwgMjAxNiBhdCAxMTowMyBBTSwgQ2hyaXN0aWFuIEvDtm5pZwo+IDxjaHJpc3RpYW4ua29l bmlnQGFtZC5jb20+IHdyb3RlOgo+ID4gTWlnaHQgYmUgdGhhdCBob3cgYW1kZ3B1IHVzZXMgdGhl IGZlbmNlIGNvbnRleHQgYW5kIHNlcXVlbmNlIG51bWJlciBpcyBhIGJpdAo+ID4gcXVlc3Rpb25h YmxlLCBidXQgdGhpcyB3aWxsIGNvbXBsZXRlbHkgYnJlYWsgaXQuCj4gCj4gWW91IG1lYW4gaXQg dHJpZXMgdG8gcXVhbGVzY2UgZmVuY2VzIGluIHRoZSBzYW1lIGNvbnRleHQgZG93biB0byBqdXN0 Cj4gdGhlIGxhc3Qgb25lPyBUaGF0J3MgaG93IGl0J3Mgc3VwcG9zZWQgdG8gYmUgZG9uZSwgYW5k Cj4gZmVuY2VfY29sbGVjdGlvbnMgZG8gYnJlYWsgdGhpcyBzb21ld2hhdC4gV2l0aG91dCBmaXhp bmcgdXAKPiBmZW5jZV9pc19sYXRlciBhbmQgZnJpZW5kcy4gU291bmRzIGxpa2UgYW1kZ3B1IGlz IGEgZ29vZCB1c2UgY2FzZSB0bwo+IG1ha2Ugc3VyZSB0aGUgY2hhbmdlcyBpbiBzZW1hbnRpY3Mg aW4gdGhlc2UgZnVuY3Rpb25zIHJlc3VsdCBpbgo+IHNlbnNpYmxlIGNvZGUuIEluIGEgd2F5IGEg ZmVuY2VfY29sbGVjdGlvbiBpcyBhIGZlbmNlIHdoZXJlIHRoZQo+IHRpbWVsaW5lIG5ldmVyIG1h dGNoZXMgd2l0aCBhbnkgb3RoZXIgdGltZWxpbmUgKHNpbmNlIGl0J3MgYQo+IGNvbWJpYXRpb24p Lgo+IAo+IEFuZCB5ZWFoIEkgdGhpbmsgZmVuY2VfY29sbGVjdGlvbiBzaG91bGQgcHJvYmFibHkg Y29tcHJlc3MgZG93biB0aGUKPiBmZW5jZXMgdG8gMSBwZXIgdGltZWxpbmUuIEJ1dCB0aGVuIHRo YXQncyBqdXN0IGFuIGltcGxlbWVudGF0aW9uCj4gZGV0YWlsIHdlIGNhbiBmaXggbGF0ZXIgb24u CgpZb3UgbWVhbiBhc2tpbmcgZm9yIGEgbmV3IGNvbnRleHQgZm9yIGV2ZXJ5IGNvbGxlY3Rpb24/ CgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbcDOS3i (ORCPT ); Fri, 15 Apr 2016 14:29:38 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:35879 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbcDOS3g convert rfc822-to-8bit (ORCPT ); Fri, 15 Apr 2016 14:29:36 -0400 Date: Fri, 15 Apr 2016 11:29:34 -0700 From: Gustavo Padovan To: Daniel Vetter Cc: Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?iso-8859-1?Q?St=E9phane?= Marchesin , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences Message-ID: <20160415182934.GB23954@joana> Mail-Followup-To: Gustavo Padovan , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?iso-8859-1?Q?St=E9phane?= Marchesin , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-04-15 Daniel Vetter : > On Fri, Apr 15, 2016 at 11:03 AM, Christian König > wrote: > > Might be that how amdgpu uses the fence context and sequence number is a bit > > questionable, but this will completely break it. > > You mean it tries to qualesce fences in the same context down to just > the last one? That's how it's supposed to be done, and > fence_collections do break this somewhat. Without fixing up > fence_is_later and friends. Sounds like amdgpu is a good use case to > make sure the changes in semantics in these functions result in > sensible code. In a way a fence_collection is a fence where the > timeline never matches with any other timeline (since it's a > combiation). > > And yeah I think fence_collection should probably compress down the > fences to 1 per timeline. But then that's just an implementation > detail we can fix later on. You mean asking for a new context for every collection? Gustavo