From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by kanga.kvack.org (Postfix) with ESMTP id A8B846B0253 for ; Fri, 15 Apr 2016 14:47:50 -0400 (EDT) Received: by mail-pa0-f71.google.com with SMTP id hb4so143040439pac.3 for ; Fri, 15 Apr 2016 11:47:50 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id xe1si5381421pab.53.2016.04.15.11.47.49 for ; Fri, 15 Apr 2016 11:47:49 -0700 (PDT) Date: Fri, 15 Apr 2016 21:47:46 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH] mm: thp: correct split_huge_pages file permission Message-ID: <20160415184746.GA132492@black.fi.intel.com> References: <1460743805-2560-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460743805-2560-1-git-send-email-yang.shi@linaro.org> Sender: owner-linux-mm@kvack.org List-ID: To: Yang Shi Cc: akpm@linux-foundation.org, aarcange@redhat.com, hughd@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org On Fri, Apr 15, 2016 at 11:10:05AM -0700, Yang Shi wrote: > split_huge_pages doesn't support get method at all, so the read permission > sounds confusing, change the permission to write only. > > And, add "\n" to the output of set method to make it more readable. > > Signed-off-by: Yang Shi Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751162AbcDOSrw (ORCPT ); Fri, 15 Apr 2016 14:47:52 -0400 Received: from mga03.intel.com ([134.134.136.65]:35183 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbcDOSrv (ORCPT ); Fri, 15 Apr 2016 14:47:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,488,1455004800"; d="scan'208";a="946069585" Date: Fri, 15 Apr 2016 21:47:46 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: akpm@linux-foundation.org, aarcange@redhat.com, hughd@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] mm: thp: correct split_huge_pages file permission Message-ID: <20160415184746.GA132492@black.fi.intel.com> References: <1460743805-2560-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460743805-2560-1-git-send-email-yang.shi@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 11:10:05AM -0700, Yang Shi wrote: > split_huge_pages doesn't support get method at all, so the read permission > sounds confusing, change the permission to write only. > > And, add "\n" to the output of set method to make it more readable. > > Signed-off-by: Yang Shi Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov