From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences Date: Fri, 15 Apr 2016 21:23:42 +0200 Message-ID: <20160415192342.GY2510@phenom.ffwll.local> References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> <20160415182934.GB23954@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A99E6ED01 for ; Fri, 15 Apr 2016 19:23:47 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id n3so8591309wmn.1 for ; Fri, 15 Apr 2016 12:23:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160415182934.GB23954@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?iso-8859-1?Q?St=E9phane?= Marchesin , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMTUsIDIwMTYgYXQgMTE6Mjk6MzRBTSAtMDcwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IDIwMTYtMDQtMTUgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPjoKPiAK PiA+IE9uIEZyaSwgQXByIDE1LCAyMDE2IGF0IDExOjAzIEFNLCBDaHJpc3RpYW4gS8O2bmlnCj4g PiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPiB3cm90ZToKPiA+ID4gTWlnaHQgYmUgdGhhdCBo b3cgYW1kZ3B1IHVzZXMgdGhlIGZlbmNlIGNvbnRleHQgYW5kIHNlcXVlbmNlIG51bWJlciBpcyBh IGJpdAo+ID4gPiBxdWVzdGlvbmFibGUsIGJ1dCB0aGlzIHdpbGwgY29tcGxldGVseSBicmVhayBp dC4KPiA+IAo+ID4gWW91IG1lYW4gaXQgdHJpZXMgdG8gcXVhbGVzY2UgZmVuY2VzIGluIHRoZSBz YW1lIGNvbnRleHQgZG93biB0byBqdXN0Cj4gPiB0aGUgbGFzdCBvbmU/IFRoYXQncyBob3cgaXQn cyBzdXBwb3NlZCB0byBiZSBkb25lLCBhbmQKPiA+IGZlbmNlX2NvbGxlY3Rpb25zIGRvIGJyZWFr IHRoaXMgc29tZXdoYXQuIFdpdGhvdXQgZml4aW5nIHVwCj4gPiBmZW5jZV9pc19sYXRlciBhbmQg ZnJpZW5kcy4gU291bmRzIGxpa2UgYW1kZ3B1IGlzIGEgZ29vZCB1c2UgY2FzZSB0bwo+ID4gbWFr ZSBzdXJlIHRoZSBjaGFuZ2VzIGluIHNlbWFudGljcyBpbiB0aGVzZSBmdW5jdGlvbnMgcmVzdWx0 IGluCj4gPiBzZW5zaWJsZSBjb2RlLiBJbiBhIHdheSBhIGZlbmNlX2NvbGxlY3Rpb24gaXMgYSBm ZW5jZSB3aGVyZSB0aGUKPiA+IHRpbWVsaW5lIG5ldmVyIG1hdGNoZXMgd2l0aCBhbnkgb3RoZXIg dGltZWxpbmUgKHNpbmNlIGl0J3MgYQo+ID4gY29tYmlhdGlvbikuCj4gPiAKPiA+IEFuZCB5ZWFo IEkgdGhpbmsgZmVuY2VfY29sbGVjdGlvbiBzaG91bGQgcHJvYmFibHkgY29tcHJlc3MgZG93biB0 aGUKPiA+IGZlbmNlcyB0byAxIHBlciB0aW1lbGluZS4gQnV0IHRoZW4gdGhhdCdzIGp1c3QgYW4g aW1wbGVtZW50YXRpb24KPiA+IGRldGFpbCB3ZSBjYW4gZml4IGxhdGVyIG9uLgo+IAo+IFlvdSBt ZWFuIGFza2luZyBmb3IgYSBuZXcgY29udGV4dCBmb3IgZXZlcnkgY29sbGVjdGlvbj8KClRoYXQg d291bGQgYmUgb25lIHNvbHV0aW9uLCBidXQgSSBmZWFyIGl0J3MgYSBiaXQgZXhwZW5zaXZlLiBI YXZpbmcgYQpzcGVjaWFsLWNhc2UgY29udGV4dCBmb3IgY29sbGVjdGlvbnMgbWlnaHQgYmUgdGhl IGJldHRlciBhcHByb2FjaC4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932081AbcDOTYc (ORCPT ); Fri, 15 Apr 2016 15:24:32 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35125 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718AbcDOTXr (ORCPT ); Fri, 15 Apr 2016 15:23:47 -0400 Date: Fri, 15 Apr 2016 21:23:42 +0200 From: Daniel Vetter To: Gustavo Padovan , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?iso-8859-1?Q?St=E9phane?= Marchesin , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences Message-ID: <20160415192342.GY2510@phenom.ffwll.local> Mail-Followup-To: Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , Laurent Pinchart , Sean Paul , =?iso-8859-1?Q?St=E9phane?= Marchesin , m.chehab@samsung.com, Maarten Lankhorst , Gustavo Padovan References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> <5710AE61.9040308@amd.com> <20160415182934.GB23954@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160415182934.GB23954@joana> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 11:29:34AM -0700, Gustavo Padovan wrote: > 2016-04-15 Daniel Vetter : > > > On Fri, Apr 15, 2016 at 11:03 AM, Christian König > > wrote: > > > Might be that how amdgpu uses the fence context and sequence number is a bit > > > questionable, but this will completely break it. > > > > You mean it tries to qualesce fences in the same context down to just > > the last one? That's how it's supposed to be done, and > > fence_collections do break this somewhat. Without fixing up > > fence_is_later and friends. Sounds like amdgpu is a good use case to > > make sure the changes in semantics in these functions result in > > sensible code. In a way a fence_collection is a fence where the > > timeline never matches with any other timeline (since it's a > > combiation). > > > > And yeah I think fence_collection should probably compress down the > > fences to 1 per timeline. But then that's just an implementation > > detail we can fix later on. > > You mean asking for a new context for every collection? That would be one solution, but I fear it's a bit expensive. Having a special-case context for collections might be the better approach. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch