From: Paul Burton <paul.burton@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
<linux-kernel@vger.kernel.org>, Jonas Gorski <jogo@openwrt.org>,
"Markos Chandras" <markos.chandras@imgtec.com>,
Alex Smith <alex.smith@imgtec.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions
Date: Fri, 15 Apr 2016 22:19:42 +0100 [thread overview]
Message-ID: <20160415211942.GA21163@NP-P-BURTON> (raw)
In-Reply-To: <20160415191640.GE7859@jhogan-linux.le.imgtec.org>
On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote:
> On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote:
> > asm/pgtable-bits.h is included in 2 assembly files and thus has to
> > in either of the assembly files that include it.
>
> That could do with rewording :-)
Oops, it appears that I accidentally some words.
Originally there was an extra line in the middle so that it read
something like:
asm/pgtable-bits.h is included in 2 assembly files and thus has to
#ifdef around C code, however nothing defined by the header is used
in either of the assembly files that include it.
Ralf: Would you be ok with adding back that line to the commit message
if this gets merged without needing a v2?
> Otherwise
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Thanks James :)
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
linux-kernel@vger.kernel.org, Jonas Gorski <jogo@openwrt.org>,
Markos Chandras <markos.chandras@imgtec.com>,
Alex Smith <alex.smith@imgtec.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions
Date: Fri, 15 Apr 2016 22:19:42 +0100 [thread overview]
Message-ID: <20160415211942.GA21163@NP-P-BURTON> (raw)
Message-ID: <20160415211942.0Rbl3ZMCCzGQSy82Zu6NB2VcrUOh2zj1N1Qu9zl01LI@z> (raw)
In-Reply-To: <20160415191640.GE7859@jhogan-linux.le.imgtec.org>
On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote:
> On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote:
> > asm/pgtable-bits.h is included in 2 assembly files and thus has to
> > in either of the assembly files that include it.
>
> That could do with rewording :-)
Oops, it appears that I accidentally some words.
Originally there was an extra line in the middle so that it read
something like:
asm/pgtable-bits.h is included in 2 assembly files and thus has to
#ifdef around C code, however nothing defined by the header is used
in either of the assembly files that include it.
Ralf: Would you be ok with adding back that line to the commit message
if this gets merged without needing a v2?
> Otherwise
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Thanks James :)
Paul
next prev parent reply other threads:[~2016-04-15 21:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 10:36 [PATCH 00/12] TLB/XPA fixes & cleanups Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 10:36 ` [PATCH 01/12] MIPS: Separate XPA CPU feature into LPA and MVH Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 10:36 ` [PATCH 02/12] MIPS: Fix HTW config on XPA kernel without LPA enabled Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 10:36 ` [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 19:16 ` James Hogan
2016-04-15 19:16 ` James Hogan
2016-04-15 21:19 ` Paul Burton [this message]
2016-04-15 21:19 ` Paul Burton
2016-04-15 10:36 ` [PATCH 04/12] MIPS: Use enums to make asm/pgtable-bits.h readable Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 20:29 ` James Hogan
2016-04-15 20:29 ` James Hogan
2016-05-11 9:38 ` Ralf Baechle
2016-04-15 10:36 ` [PATCH 05/12] MIPS: mm: Standardise on _PAGE_NO_READ, drop _PAGE_READ Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 21:22 ` James Hogan
2016-04-15 21:22 ` James Hogan
2016-04-18 9:03 ` Paul Burton
2016-04-18 9:03 ` Paul Burton
2016-04-18 9:10 ` James Hogan
2016-04-18 9:10 ` James Hogan
2016-04-15 10:36 ` [PATCH 06/12] MIPS: mm: Unify pte_page definition Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 23:16 ` James Hogan
2016-04-15 23:16 ` James Hogan
2016-04-15 10:36 ` [PATCH 07/12] MIPS: mm: Fix MIPS32 36b physical addressing (alchemy, netlogic) Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 22:17 ` James Hogan
2016-04-15 22:17 ` James Hogan
2016-04-15 10:36 ` [PATCH 08/12] MIPS: mm: Don't clobber $1 on XPA TLB refill Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 10:36 ` [PATCH 09/12] MIPS: mm: Pass scratch register through to iPTE_SW Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 22:28 ` James Hogan
2016-04-15 22:28 ` James Hogan
2016-04-15 10:36 ` [PATCH 10/12] MIPS: mm: Be more explicit about PTE mode bit handling Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 10:36 ` [PATCH 11/12] MIPS: mm: Simplify build_update_entries Paul Burton
2016-04-15 10:36 ` Paul Burton
2016-04-15 23:09 ` James Hogan
2016-04-15 23:09 ` James Hogan
2016-04-15 10:37 ` [PATCH 12/12] MIPS: mm: Don't do MTHC0 if XPA not present Paul Burton
2016-04-15 10:37 ` Paul Burton
2016-05-10 12:44 ` [PATCH 00/12] TLB/XPA fixes & cleanups Ralf Baechle
2016-05-10 17:47 ` Florian Fainelli
2016-05-11 10:03 ` Ralf Baechle
2016-05-11 19:17 ` Florian Fainelli
2016-05-11 21:15 ` Maciej W. Rozycki
2016-05-11 21:15 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415211942.GA21163@NP-P-BURTON \
--to=paul.burton@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=alex.smith@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=jogo@openwrt.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.