From: Dan Carpenter <dan.carpenter@oracle.com>
To: Slawomir Stepien <sst@poczta.fm>
Cc: Matt Ranostay <mranostay@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
Date: Sat, 16 Apr 2016 09:48:39 +0000 [thread overview]
Message-ID: <20160416094839.GF4298@mwanda> (raw)
In-Reply-To: <20160415145641.GA19346@x220.localdomain>
On Fri, Apr 15, 2016 at 04:56:41PM +0200, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
> > On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > > This fixes the error reported by checkpatch.pl:
> > >
> > > ERROR: that open brace { should be on the previous line
> > >
> > > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > > ---
> > > drivers/iio/light/apds9960.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > > index a6af56a..ade18aa 100644
> > > --- a/drivers/iio/light/apds9960.c
> > > +++ b/drivers/iio/light/apds9960.c
> > > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > > };
> > >
> > > /* integration time in us */
> > > -static const int apds9960_int_time[][2] > > > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > > +static const int apds9960_int_time[][2] = {
> > > + { 28000, 246},
> > > + {100000, 219},
> > > + {200000, 182},
> > > + {700000, 0}
> > Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
Yeah. Looks fine.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Slawomir Stepien <sst@poczta.fm>
Cc: Matt Ranostay <mranostay@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 01/10] iio: light apds9960: fix wrong use of brace
Date: Sat, 16 Apr 2016 12:48:39 +0300 [thread overview]
Message-ID: <20160416094839.GF4298@mwanda> (raw)
In-Reply-To: <20160415145641.GA19346@x220.localdomain>
On Fri, Apr 15, 2016 at 04:56:41PM +0200, Slawomir Stepien wrote:
> On Apr 14, 2016 16:29, Matt Ranostay wrote:
> > On Thu, Apr 14, 2016 at 12:36 PM, Slawomir Stepien <sst@poczta.fm> wrote:
> > > This fixes the error reported by checkpatch.pl:
> > >
> > > ERROR: that open brace { should be on the previous line
> > >
> > > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > > ---
> > > drivers/iio/light/apds9960.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> > > index a6af56a..ade18aa 100644
> > > --- a/drivers/iio/light/apds9960.c
> > > +++ b/drivers/iio/light/apds9960.c
> > > @@ -321,8 +321,12 @@ static const struct iio_chan_spec apds9960_channels[] = {
> > > };
> > >
> > > /* integration time in us */
> > > -static const int apds9960_int_time[][2] =
> > > - { {28000, 246}, {100000, 219}, {200000, 182}, {700000, 0} };
> > > +static const int apds9960_int_time[][2] = {
> > > + { 28000, 246},
> > > + {100000, 219},
> > > + {200000, 182},
> > > + {700000, 0}
> > Extra space between the comma and zero. Or was this intended for alignment?
>
> Just for alignment. Are you OK with that?
Yeah. Looks fine.
regards,
dan carpenter
next prev parent reply other threads:[~2016-04-16 9:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 19:36 [PATCH 00/10] iio: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-14 19:36 ` [PATCH 01/10] iio: light apds9960: fix wrong use of brace Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-14 23:29 ` Matt Ranostay
2016-04-14 23:29 ` Matt Ranostay
2016-04-15 14:56 ` Slawomir Stepien
2016-04-15 14:56 ` Slawomir Stepien
2016-04-16 9:48 ` Dan Carpenter [this message]
2016-04-16 9:48 ` Dan Carpenter
2016-04-16 12:30 ` Jonathan Cameron
2016-04-16 12:30 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 02/10] iio: inkern: add a missing space before if Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:31 ` Jonathan Cameron
2016-04-16 12:31 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 03/10] iio: adc: vf610_adc: fix case label indent Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:31 ` Jonathan Cameron
2016-04-16 12:31 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 04/10] iio: adc: mcp3422: remove spaces before comma Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:32 ` Jonathan Cameron
2016-04-16 12:32 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 05/10] iio: adc: at91_adc: fix errors reported by checkpatch.pl Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:33 ` Jonathan Cameron
2016-04-16 12:33 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 06/10] iio: adc: ad799x: remove space before comma Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:34 ` Jonathan Cameron
2016-04-16 12:34 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 07/10] iio: common: ms_sensors: use tab for indention Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:34 ` Jonathan Cameron
2016-04-16 12:34 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 08/10] iio: common: hid-sensors: " Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:35 ` Jonathan Cameron
2016-04-16 12:35 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 09/10] iio: magnetometer: ak8975: put else and brace at the same line Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:35 ` Jonathan Cameron
2016-04-16 12:35 ` Jonathan Cameron
2016-04-14 19:36 ` [PATCH 10/10] iio: pressure: ms5611: use tab for indention Slawomir Stepien
2016-04-14 19:36 ` Slawomir Stepien
2016-04-16 12:40 ` Jonathan Cameron
2016-04-16 12:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416094839.GF4298@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.