From: Jonathan Corbet <corbet@lwn.net>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Russell King <rmk@arm.linux.org.uk>,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep
Date: Sat, 16 Apr 2016 10:47:49 -0600 [thread overview]
Message-ID: <20160416104749.49c74c20@lwn.net> (raw)
In-Reply-To: <5711743B.3030207@hurleysoftware.com>
On Fri, 15 Apr 2016 16:07:39 -0700
Peter Hurley <peter@hurleysoftware.com> wrote:
> > I'm missing something here.
>
> Yes.
>
> The analysis above is required to show that the API contract asserted by
> the proposed change to the documentation is currently true in the code,
> which is what I care about.
Yes, but the analysis says nothing about what uart_break_ctl() itself
might do, so by itself, it provides no guarantee for break_ctl(). That
was my sticking point since somebody clearly put that line in there for a
reason.
Looking at the code, it's pretty obvious that uart_break_ctl() isn't
acquiring any spinlocks. The documentation line in question has been
there, unchanged, since the beginning of the Git era. The patch is
obviously fine, and I've applied it, but I did tweak the changelog some.
Thanks,
jon
next prev parent reply other threads:[~2016-04-16 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 9:08 [PATCH 0/4] serial: doc: Low Level Serial API Documentation Improvements (take two) Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 1/4] serial: doc: Re-add paragraph documenting uart_console_write() Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 2/4] serial: doc: .(un)throttle() depends on hardware assisted flow control Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 3/4] serial: doc: .(un)throttle() are serialized by the tty layer Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 4/4] serial: doc: .break_ctl() may sleep Geert Uytterhoeven
2016-04-15 22:01 ` Jonathan Corbet
2016-04-15 22:31 ` Peter Hurley
2016-04-15 22:41 ` Jonathan Corbet
2016-04-15 23:07 ` Peter Hurley
2016-04-16 16:47 ` Jonathan Corbet [this message]
2016-04-18 8:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416104749.49c74c20@lwn.net \
--to=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.