All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT
Date: Sun, 17 Apr 2016 02:33:45 -0700	[thread overview]
Message-ID: <20160417093345.GA23092@dtor-ws> (raw)
In-Reply-To: <571291F8.1010804@kernel.org>

On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote:
> On 10/04/16 20:22, Ksenija Stanojevic wrote:
> > Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
> > device to help userspace classify it.
> > 
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> Sounds correct to me.  Dmitry?

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> > ---
> >  drivers/iio/adc/mxs-lradc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
> > index 07287af..e4c4c5c 100644
> > --- a/drivers/iio/adc/mxs-lradc.c
> > +++ b/drivers/iio/adc/mxs-lradc.c
> > @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> >  	__set_bit(EV_ABS, input->evbit);
> >  	__set_bit(EV_KEY, input->evbit);
> >  	__set_bit(BTN_TOUCH, input->keybit);
> > +	__set_bit(INPUT_PROP_DIRECT, input->propbit);
> >  	input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> >  	input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> >  	input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
> > 
> 

-- 
Dmitry

  reply	other threads:[~2016-04-17  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1460316098.git.ksenija.stanojevic@gmail.com>
2016-04-10 19:22 ` [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT Ksenija Stanojevic
2016-04-16 19:26   ` Jonathan Cameron
2016-04-17  9:33     ` Dmitry Torokhov [this message]
2016-04-17  9:48       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160417093345.GA23092@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.