From: Mike Snitzer <snitzer@redhat.com>
To: Ahmed Samy <f.fallen45@gmail.com>
Cc: dm-devel@redhat.com, stable@vger.kernel.org
Subject: Re: dm cache metadata: fix cmd_read_lock acquiring write lock
Date: Sun, 17 Apr 2016 11:23:43 -0400 [thread overview]
Message-ID: <20160417152343.GA26731@redhat.com> (raw)
In-Reply-To: <1460871429-22523-1-git-send-email-f.fallen45@gmail.com>
On Sun, Apr 17 2016 at 1:37P -0400,
Ahmed Samy <f.fallen45@gmail.com> wrote:
> commit 9567366fefdd ("dm cache metadata: fix READ_LOCK macros and cleanup WRITE_LOCK macros")
> seemed to use down_write instead of down_read in cmd_read_lock(), yet
> releasing it with up_read() in READ_UNLOCK. Fix it.
>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>
Ugh, very frustrating -- I must've looked at this code 3 different times
to try to make sure I didn't have a thinko. And strangely sparse didn't
catch this locking bug (from cut-n-paste).
Anyway, thanks... I'll see if I can get this to Linus ASAP.
Mike
prev parent reply other threads:[~2016-04-17 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 5:37 [PATCH] dm cache metadata: fix cmd_read_lock acquiring write lock Ahmed Samy
2016-04-17 15:23 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160417152343.GA26731@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=f.fallen45@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.