Re: [Libtirpc-devel] [PATCH 7/7] Deduplicate extern "C" blocks

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On 17 Apr 2016 11:11, Felix Janda wrote:
> Signed-off-by: Felix Janda <felix.janda@posteo.de>
> ---
>  tirpc/rpc/auth.h      | 62 +++++++--------------------------------------------
>  tirpc/rpc/auth_des.h  | 14 +++++-------
>  tirpc/rpc/clnt.h      | 50 +++++++----------------------------------
>  tirpc/rpc/clnt_soc.h  | 27 +++++-----------------
>  tirpc/rpc/des_crypt.h | 20 +++++------------
>  tirpc/rpc/rpc.h       | 14 +++++-------
>  tirpc/rpc/svc.h       | 55 ++++++---------------------------------------
>  tirpc/rpc/svc_soc.h   | 38 +++++--------------------------
>  tirpc/rpc/xdr.h       | 15 +++++--------
>  9 files changed, 54 insertions(+), 241 deletions(-)
> 
> diff --git a/tirpc/rpc/auth.h b/tirpc/rpc/auth.h
> index 5f8ea72..f743034 100644
> --- a/tirpc/rpc/auth.h
> +++ b/tirpc/rpc/auth.h
> @@ -46,6 +46,10 @@
>  #ifndef _TIRPC_AUTH_H
>  #define  _TIRPC_AUTH_H
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rpc/xdr.h>
>  #include <rpc/clnt_stat.h>
>  #include <sys/socket.h>

it isn't normal to wrap includes in extern C.  header files should only
be wrapping their own local content.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]