From: Cyril Bur <cyrilbur@gmail.com>
To: OpenBMC Patches <openbmc-patches@stwcx.xyz>,
Brad Bishop <bradleyb@us.ibm.com>
Cc: openbmc@lists.ozlabs.org
Subject: Re: [PATCH skeleton 0/5] Remove custom org.openbmc.Object.ObjectMapper usage
Date: Mon, 18 Apr 2016 10:43:03 +1000 [thread overview]
Message-ID: <20160418104303.35aedd82@camb691> (raw)
In-Reply-To: <1460649655-15109-1-git-send-email-openbmc-patches@stwcx.xyz>
On Thu, 14 Apr 2016 11:00:50 -0500
OpenBMC Patches <openbmc-patches@stwcx.xyz> wrote:
Hi Brad,
The series looks good to me but I have a question that I keep asking and I'm
not sure I've ever seen a response.
Is it worth continuing to patch (and in this case cleanup) skeleton code? I was
under the impression that this wouldn't live on and that this was for bringup?
> <!-- Reviewable:start -->
> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/openbmc/skeleton/61)
> <!-- Reviewable:end -->
>
>
> https://github.com/openbmc/skeleton/pull/61
>
> Brad Bishop (5):
> Remove fan control support from Palmetto
> Add gitignore file
> Whitespace fixes for objects/*.c
> Fix compiler warnings for objects/*
> Remove custom org.openbmc.Object.ObjectMapper
>
> .gitignore | 6 +
> Makefile | 28 +-
> bin/Palmetto.py | 7 -
> bin/system_manager.py | 4 +-
> includes/object_mapper.c | 31 --
> includes/object_mapper.h | 10 -
> includes/openbmc.h | 2 +-
> objects/board_vpd_obj.c | 119 ++---
> objects/button_power_obj.c | 345 ++++++------
> objects/button_reset_obj.c | 180 +++----
> objects/control_bmc_barreleye.c | 496 +++++++++--------
> objects/control_bmc_obj.c | 445 ++++++++--------
> objects/control_host_obj.c | 540 +++++++++----------
> objects/fan_generic_obj.c | 263 +++++----
> objects/flash_bios_obj.c | 838 ++++++++++++++---------------
> objects/flasher_obj.c | 877 +++++++++++++++---------------
> objects/host_watchdog_obj.c | 365 +++++++------
> objects/hwmons_barreleye.c | 433 ++++++++-------
> objects/hwmons_palmetto.c | 422 +++++++--------
> objects/led_controller.c | 1124 ++++++++++++++++++++-------------------
> objects/pcie_slot_present_obj.c | 327 ++++++------
> objects/power_control_obj.c | 633 +++++++++++-----------
> 22 files changed, 3656 insertions(+), 3839 deletions(-)
> create mode 100644 .gitignore
> delete mode 100644 includes/object_mapper.c
> delete mode 100644 includes/object_mapper.h
> mode change 100755 => 100644 objects/button_reset_obj.c
> mode change 100755 => 100644 objects/control_host_obj.c
> mode change 100755 => 100644 objects/led_controller.c
>
prev parent reply other threads:[~2016-04-18 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 16:00 [PATCH skeleton 0/5] Remove custom org.openbmc.Object.ObjectMapper usage OpenBMC Patches
2016-04-14 16:00 ` [PATCH skeleton 1/5] Remove fan control support from Palmetto OpenBMC Patches
2016-04-14 16:00 ` [PATCH skeleton 2/5] Add gitignore file OpenBMC Patches
2016-04-14 16:00 ` [PATCH skeleton 3/5] Whitespace fixes for objects/*.c OpenBMC Patches
2016-04-14 16:00 ` [PATCH skeleton 4/5] Fix compiler warnings for objects/* OpenBMC Patches
2016-04-18 0:37 ` Cyril Bur
2016-04-21 14:15 ` Brad Bishop
2016-04-14 16:00 ` [PATCH skeleton 5/5] Remove custom org.openbmc.Object.ObjectMapper OpenBMC Patches
2016-04-18 0:43 ` Cyril Bur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418104303.35aedd82@camb691 \
--to=cyrilbur@gmail.com \
--cc=bradleyb@us.ibm.com \
--cc=openbmc-patches@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.