From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/atomic-helper: Print an error if vblank wait times out
Date: Mon, 18 Apr 2016 14:31:13 +0200 [thread overview]
Message-ID: <20160418123113.GC2510@phenom.ffwll.local> (raw)
In-Reply-To: <1460978973-24945-2-git-send-email-ville.syrjala@linux.intel.com>
On Mon, Apr 18, 2016 at 02:29:33PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Vblank waits timing out is no a normal thing to happen, so let's inform
> people when it happens.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Applied to drm-misc, let's see how much it blows up. We /should/ be
filtering out entirely defunct vblank implementations already by checking
vblank_get() ...
-Daniel
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 7bf678ee7f81..40c7b268a9bc 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -1103,6 +1103,8 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev,
> drm_crtc_vblank_count(crtc),
> msecs_to_jiffies(50));
>
> + WARN(!ret, "[CRTC:%d] vblank wait timed out\n", crtc->base.id);
> +
> drm_crtc_vblank_put(crtc);
> }
> }
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-18 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 11:29 [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message ville.syrjala
2016-04-18 11:29 ` [PATCH 2/2] drm/atomic-helper: Print an error if vblank wait times out ville.syrjala
2016-04-18 12:31 ` Daniel Vetter [this message]
2016-04-18 11:43 ` [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message Maarten Lankhorst
2016-04-18 15:56 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418123113.GC2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.