Re: [PATCH 00/21] IB/hfi1: First round of fixes for 4.7

[Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

On Mon, Apr 18, 2016 at 09:38:43AM -0400, Dennis Dalessandro wrote:
> On Mon, Apr 18, 2016 at 03:19:44PM +0300, Leon Romanovsky wrote:
> >On Mon, Apr 18, 2016 at 08:07:55AM -0400, Dennis Dalessandro wrote:
> >>On Mon, Apr 18, 2016 at 10:09:36AM +0300, Leon Romanovsky wrote:
> >>>On Tue, Apr 12, 2016 at 10:49:52AM -0700, Dennis Dalessandro wrote:
> >>>>These patches do some clean ups and fix issues which may not be appropriate for
> >>>>an RC so we are targeting these for 4.7. The current patch series applies on top
> >>>>of the "Important bug fixes for 4.6 RC" patch set submitted just prior to this.
> >>>>
> >>>>Patches can be viewed in my GitHub repo at:
> >>>>https://github.com/ddalessa/kernel/tree/for-4.7.
> >>>
> >>>Please follow SubmittingPatches guide - submitting fixes section.
> >>>
> >>
> >>Can you please be more specific with what your complaint is here? Which
> >>section are you referring to? There is no "submitting fixes" section in the
> >>document.
> >
> >
> >If your patch fixes a bug in a specific commit, e.g. you found an issue
> >using git-bisect, please use the 'Fixes:' tag with the first 12 characters of
> >the SHA-1 ID, and the one line summary.  For example:
> >
> > Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
> >
> >https://www.kernel.org/doc/Documentation/SubmittingPatches
> 
> When there is a specific commit that broke something, sure. I think folks
> usually add that when appropriate, it's not always the case. "Fix" is a
> general term in a lot of patches. Could be day-0 bug, or the result of
> multiple commits coming together, etc.

Fixes line will help to the users and developers to get a sense if the
failure they see can be related to the code which they have (SHA-1).

Especially, it is valuable when it comes from the vendor who does
extensive testing and can perfectly explain what they are fixing.

> 
> Regardless, is there a patch here in this series that you need more back
> story on?  Please let me know and I'll track it down.

Every commit which suppose to fix something.


> 
> -Denny

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]