From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message Date: Mon, 18 Apr 2016 18:56:45 +0300 Message-ID: <20160418155645.GH4329@intel.com> References: <1460978973-24945-1-git-send-email-ville.syrjala@linux.intel.com> <5714C851.4040703@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5714C851.4040703@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMTgsIDIwMTYgYXQgMDE6NDM6MTNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTgtMDQtMTYgb20gMTM6Mjkgc2NocmVlZiB2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gPgo+ID4gV2hlbiBhIHZibGFuayB3YWl0IHRpbWVzIG91dCBpbiBp bnRlbF9hdG9taWNfd2FpdF9mb3JfdmJsYW5rcygpIHdlIGp1c3QKPiA+IGdldCBhIGNyeXB0aWMg J1dBUk5fT04oIXJldCknIGJhY2t0cmFjZSBpbiBkbWVzZy4gUmVwYWNlIGl0IHdpdGgKPiA+IHNv bWV0aGluZyB0aGF0IHRlbGxzIHlvdSB3aGF0IGFjdHVhbGx5IGhhcHBlbmVkLgo+ID4KPiA+IENj OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o LSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA0Y2Nh MTU1Mzc2YmUuLjdiZGJlNGIwMzU5MSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiBAQCAtMTM1MjMsNyArMTM1MjMsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9h dG9taWNfd2FpdF9mb3JfdmJsYW5rcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAkJCQkJ ZHJtX2NydGNfdmJsYW5rX2NvdW50KGNydGMpLAo+ID4gIAkJCQltc2Vjc190b19qaWZmaWVzKDUw KSk7Cj4gPiAgCj4gPiAtCQlXQVJOX09OKCFscmV0KTsKPiA+ICsJCVdBUk4oIWxyZXQsICJwaXBl ICVjIHZibGFuayB3YWl0IHRpbWVkIG91dFxuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPiA+ICAKPiA+ ICAJCWRybV9jcnRjX3ZibGFua19wdXQoY3J0Yyk7Cj4gPiAgCX0KPiBUaGlzIGhlbHBlciBmdW5j dGlvbiB3YXMgbmV2ZXIgbWVhbnQgdG8gbGFzdCBhcyBsb25nIGFzIGl0IGRpZC4gOigKPiAKPiBS ZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4Lmlu dGVsLmNvbT4KClB1c2hlZCB0byBkaW5xLiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK