From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: fix nvme_ns_remove() deadlock
Date: Mon, 18 Apr 2016 22:37:14 +0200 [thread overview]
Message-ID: <20160418203714.GA6484@lst.de> (raw)
In-Reply-To: <20160418183214.GC4640@localhost.localdomain>
On Mon, Apr 18, 2016@06:32:15PM +0000, Keith Busch wrote:
> This fixes one deadlock by introducing another.
>
> The reason we don't hold the namespace lock during nvme_ns_remove is
> because del_gendisk blocks until all IO is flushed. If the controller
> fails during this, you'll deadlock nvme_dev_disable as it tries to
> recover.
Should we switch to RCU freeing the namespace structure? If we do
that nvme_start_queues, nvme_stop_queues and nvme_kill_queues would
be able to get away with only a RCU read side critical section,
and Mings should be fine on top of that.
next prev parent reply other threads:[~2016-04-18 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 18:21 [PATCH] nvme: fix nvme_ns_remove() deadlock Ming Lin
2016-04-18 18:32 ` Keith Busch
2016-04-18 20:37 ` Christoph Hellwig [this message]
2016-04-18 22:56 ` Ming Lin
2016-04-19 18:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418203714.GA6484@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.