From: Stephen Hemminger <stephen@networkplumber.org>
To: Peter Heise <mail@pheise.de>
Cc: arvid.brodin@alten.se, davem@davemloft.net,
hannes@stressinduktion.org, sd@queasysnail.net, henrik@austad.us,
nikolay@cumulusnetworks.com, tgraf@suug.ch,
linville@tuxdriver.com, gospo@cumulusnetworks.com,
dsa@cumulusnetworks.com, eranbe@mellanox.com, ast@plumgrid.com,
netdev@vger.kernel.org, peter.heise@airbus.com
Subject: Re: [PATCH net-next] net/hsr: Added support for HSR v1
Date: Tue, 19 Apr 2016 08:21:00 -0700 [thread overview]
Message-ID: <20160419082100.237f1b6e@xeon-e3> (raw)
In-Reply-To: <20160413115222.GA42572@aircraft-controller>
On Wed, 13 Apr 2016 13:52:22 +0200
Peter Heise <mail@pheise.de> wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 9427f17..bb3a90b 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -773,6 +773,7 @@ enum {
> IFLA_HSR_SLAVE1,
> IFLA_HSR_SLAVE2,
> IFLA_HSR_MULTICAST_SPEC, /* Last byte of supervision addr */
> + IFLA_HSR_VERSION, /* HSR version */
> IFLA_HSR_SUPERVISION_ADDR, /* Supervision frame multicast addr */
> IFLA_HSR_SEQ_NR,
You added a new value into the middle of an enumeration field.
This breaks kernel ABI. Older applications (like iproute) would see the wrong
values.
Please submit a new change which moves HSR_VERSION to the end of the enum
next prev parent reply other threads:[~2016-04-19 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:52 [PATCH net-next] net/hsr: Added support for HSR v1 Peter Heise
2016-04-15 21:08 ` David Miller
2016-04-19 15:21 ` Stephen Hemminger [this message]
2016-04-19 16:12 ` David Miller
[not found] ` <8104_1461082351_571658EF_8104_4642_1_20160419.121227.1437003570791513649.davem@davemloft.net>
2016-04-20 7:10 ` AW: " Heise, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419082100.237f1b6e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=arvid.brodin@alten.se \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eranbe@mellanox.com \
--cc=gospo@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=henrik@austad.us \
--cc=linville@tuxdriver.com \
--cc=mail@pheise.de \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=peter.heise@airbus.com \
--cc=sd@queasysnail.net \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.