From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
stable@vger.kernel.org, ОлегМороз <oleg.moroz@mcc.vniiem.ru>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sunjin Yang" <fan4326@gmail.com>, "Rob Groner" <rgroner@rtd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jiang Liu" <jiang.liu@linux.intel.com>
Subject: Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and
Date: Tue, 19 Apr 2016 11:41:48 +0200 [thread overview]
Message-ID: <20160419094148.GG3886@suse.de> (raw)
In-Reply-To: <20160418144336.GA17863@localhost>
On Mon, Apr 18, 2016 at 09:43:36AM -0500, Bjorn Helgaas wrote:
> That might work, but the problem seems to be that we aren't enabling
> IRQs correctly, so I'd rather have a fix that explicitly addresses
> IRQs than one that relies on some non-obvious connection between
> enabling BARs and IRQs.
Yeah, either we or the BIOS does something wrong. The bugzilla entry
states that it works with pci=routeirq. The dmesg from kernel 4.3 shows
that per default ACPI routing is used for IRQs.
The difference this makes in the code is the pcibios_enable_irq function
pointer. For ACPI it points to acpi_pci_irq_enable and in the
pci=routeirq case to pirq_enable_irq.
So the problem appears when acpi_pci_irq_enable is used with device
resources disabled. This might very well also be a bios issue that we
have to work around, no?
Joerg
next prev parent reply other threads:[~2016-04-19 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 5:56 [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 1/3] Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled" Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 2/3] Revert "PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed" Bjorn Helgaas
2016-04-13 5:57 ` [PATCH 3/3] Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()" Bjorn Helgaas
2016-04-14 15:50 ` [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Joerg Roedel
2016-04-15 15:08 ` Bjorn Helgaas
2016-04-18 11:50 ` Joerg Roedel
2016-04-18 14:43 ` Bjorn Helgaas
2016-04-19 9:41 ` Joerg Roedel [this message]
2016-04-18 1:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419094148.GG3886@suse.de \
--to=jroedel@suse.de \
--cc=bhelgaas@google.com \
--cc=fan4326@gmail.com \
--cc=helgaas@kernel.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oleg.moroz@mcc.vniiem.ru \
--cc=rafael@kernel.org \
--cc=rgroner@rtd.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.