From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: fjes: Introduce spinlock for rx_status
Date: Tue, 19 Apr 2016 09:51:18 +0000 [thread overview]
Message-ID: <20160419095118.GA1977@mwanda> (raw)
Hello Taku Izumi,
The patch bd5a256991f9: "fjes: Introduce spinlock for rx_status" from
Apr 15, 2016, leads to the following static checker warning:
drivers/net/fjes/fjes_main.c:827 fjes_change_mtu()
error: double lock 'spin_lock:&hw->rx_status_lock'
drivers/net/fjes/fjes_main.c
822 spin_lock_irqsave(&hw->rx_status_lock, flags);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Locked.
823 for (epidx = 0; epidx < hw->max_epid; epidx++) {
824 if (epidx = hw->my_epid)
825 continue;
826
827 spin_lock_irqsave(&hw->rx_status_lock, flags);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Deadlocked.
828 fjes_hw_setup_epbuf(&hw->ep_shm_info[epidx].tx,
829 netdev->dev_addr,
830 netdev->mtu);
831
832 hw->ep_shm_info[epidx].tx.info->v1i.rx_status | 833 FJES_RX_MTU_CHANGING_DONE;
834 spin_unlock_irqrestore(&hw->rx_status_lock, flags);
835 }
836
837 netif_tx_wake_all_queues(netdev);
838 netif_carrier_on(netdev);
839 napi_enable(&adapter->napi);
840 napi_schedule(&adapter->napi);
841 }
regards,
dan carpenter
reply other threads:[~2016-04-19 9:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419095118.GA1977@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.