From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.server123.net (Postfix) with ESMTPS
 for <dm-crypt@saout.de>; Tue, 19 Apr 2016 17:22:15 +0200 (CEST)
Date: Tue, 19 Apr 2016 11:22:12 -0400
From: Mike Frysinger <vapier@gentoo.org>
Message-ID: <20160419152212.GG5369@vapier.lan>
References: <1461046565-16999-1-git-send-email-vapier@gentoo.org>
 <5715D177.5000701@gmail.com> <20160419065344.GE5369@vapier.lan>
 <5715F52C.7050200@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="1YtYzP3stTOlsn9I"
Content-Disposition: inline
In-Reply-To: <5715F52C.7050200@gmail.com>
Subject: Re: [dm-crypt] [PATCH] include sys/sysmacros.h for
	major/minor/makedev
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt/>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
 <mailto:dm-crypt-request@saout.de?subject=subscribe>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-crypt@saout.de


--1YtYzP3stTOlsn9I
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 19 Apr 2016 11:06, Milan Broz wrote:
> On 04/19/2016 08:53 AM, Mike Frysinger wrote:
> > On 19 Apr 2016 08:34, Milan Broz wrote:
> >> On 04/19/2016 08:16 AM, Mike Frysinger wrote:
> ...
> >>> +#include <sys/sysmacros.h>
> >>
> >> Shouldn't we also check for existence of this header in autoconf?
> >> I do not think it is present on all systems (FreeBSD?).
> >=20
> > i couldn't tell how portable this code base was trying to be or if it
> > was assuming Linux.  if you want to be portable w/autoconf, should be
> > easy to do:
> > (1) call AC_HEADER_MAJOR in configure.ac
> > (2) use the idiom:
> > #ifdef MAJOR_IN_MKDEV
> > # include <sys/mkdev.h>
> > #elif defined(MAJOR_IN_SYSMACROS)
> > # include <sys/sysmacros.h>
> > #endif
>=20
> I fixed it with this commit
> https://gitlab.com/cryptsetup/cryptsetup/commit/54c4b1656f93997ae5624051c=
91ea10249e5a823

that'll work for us too.  thanks!
-mike

--1YtYzP3stTOlsn9I
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXFk0kAAoJEEFjO5/oN/WBgvcQANDVKfzEd+/ijv2Mcq/mjekc
X6b2+tI07GCb3XKvrQ6ZQ1EB8bLM78inYgquoLiWky9KRoDhRbcQPReP/2duqeib
fjM24npML5RSH+AkKsIkDMAtzOExfm79ELZXn0/Mr70THlCjFnzfuSRwnqdXrCow
3Z+ndKGXT4Q4NsJV0STtp4+V3efq4uCdc+sKHzcpGH1TFYEe2WJ23aLqkrZFNYR9
dQOivGRLycybL31pW//OpSIx9NpKYRTmuPOZN/UPPxxkLobqaQBp6pZjk8DSuQ5E
VPibgG7gu+3jAeKNoVwzJTIjP2UQXk3pyTZa5+2Sf6VKitYJq110vBPfewC8dMSF
deXfkngdVVi7EXY7wixryiMR8ER+YyU1HPw7KNKjPVruOl8Qjut/qeqA2mVTocOk
3htAlr9sXby83JhxvQqBc0rXPBzH1XcO5gd/l3FzE16tyMZ2yDu5HaVk8TqM624G
DmZG/fFKZT5TRRIDPxrc4oNCH7DSBYXBKlcRtdq9/Z292yaYV1+nDZXj0DOPp0ZE
3vMmZUM4v7JlTvpisrS02nlAeDaP7EzGE8jHLsL/1cIktnVhDD0YNsj5BO6X202n
z090WkxuoN3fibWekYQcfxq0YBDVDGRUx/hhbfcHLg9ru21VYQPWhhXqxonDOlux
Y/U+cECwSD+oB5Jmzw25
=LStQ
-----END PGP SIGNATURE-----

--1YtYzP3stTOlsn9I--