From: Greg KH <gregkh@linuxfoundation.org>
To: Nikhilesh Reddy <reddyn@codeaurora.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Umount failing due to a file leak on 3.18 Android
Date: Wed, 20 Apr 2016 14:55:58 +0900 [thread overview]
Message-ID: <20160420055558.GB6031@kroah.com> (raw)
In-Reply-To: <5716DAC3.4070404@codeaurora.org>
On Tue, Apr 19, 2016 at 06:26:27PM -0700, Nikhilesh Reddy wrote:
> Hi
>
> I am looking into a bug that results in umount failures ( since there is a mount ref from the leaked file that is never freed on the mount )
>
> The issue seems to be a result of the following callstack
>
> 39.958104: <6> Call trace:
> 39.958108: <2> [<ffffffc0001baa58>] fput+0x1e0/0x1f8
> 39.958113: <2> [<ffffffc0001b6ce8>] filp_close+0xa0/0xb8
> 39.958119: <2> [<ffffffc0001d3ca8>] put_files_struct+0x88/0xf0
> 39.958123: <2> [<ffffffc000973c40>] binder_deferred_func+0x6a8/0x704
> 39.958129: <2> [<ffffffc0000ba32c>] process_one_work+0x238/0x3f0
> 39.958133: <2> [<ffffffc0000bb160>] worker_thread+0x2f8/0x418
>
> What seems to occur is that once in a while a file ( say a.txt) is fput in the above stack
> right as the task is being killed
>
> And then we see that the fput schedules a delayed_fput_work on this file
>
> But when the function delayed_fput() is actually run :
> the file that was put i.e this a.txt is not in the delayed_fput_list
>
> Any chance you can help me get to the bottom of this leak?
> I dont understand why the delayed_fput_list is missing the file.
3.18 is very old, can you duplicate this on 4.5 or newer?
thanks,
greg k-h
prev parent reply other threads:[~2016-04-20 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 1:26 Umount failing due to a file leak on 3.18 Android Nikhilesh Reddy
2016-04-20 1:29 ` Nikhilesh Reddy
2016-04-20 1:57 ` Nikhilesh Reddy
2016-04-20 5:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420055558.GB6031@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reddyn@codeaurora.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.