From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA Date: Wed, 20 Apr 2016 13:17:30 +0200 Message-ID: <20160420111730.GL2510@phenom.ffwll.local> References: <20160419123028.GI1990@wotan.suse.de> <1461069238-31539-1-git-send-email-chris@chris-wilson.co.uk> <1461069238-31539-4-git-send-email-chris@chris-wilson.co.uk> <20160420091054.GL1990@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160420091054.GL1990@wotan.suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Luis R. Rodriguez" Cc: David Hildenbrand , netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Peter Zijlstra (Intel)" , Daniel Vetter , Dan Williams , Yishai Hadas , Ingo Molnar , linux-rdma@vger.kernel.org List-Id: linux-rdma@vger.kernel.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMTE6MTA6NTRBTSArMDIwMCwgTHVpcyBSLiBSb2RyaWd1 ZXogd3JvdGU6Cj4gUmVhc29uIEkgYXNrIGlzIHNpbmNlIEkgbm90aWNlZCBhIHdoaWxlIGFnbyBh IGxvdCBvZiBkcml2ZXJzCj4gd2VyZSB1c2luZyBpbmZvLT5maXguc21lbV9zdGFydCBhbmQgaW5m by0+Zml4LnNtZW1fbGVuIGNvbnNpc3RlbnRseQo+IGZvciB0aGVpciBpb3JlbWFwJ2QgYXJlYXMg aXQgbWlnaHQgbWFrZSBzZW5zZSBpbnN0ZWFkIHRvIGxldCB0aGUKPiBpbnRlcm5hbCBmcmFtZWJ1 ZmZlciAocmVnaXN0ZXJfZnJhbWVidWZmZXIoKSkgb3B0aW9uYWxseSBtYW5hZ2UgdGhlCj4gaW9y ZW1hcF93YygpIGZvciBkcml2ZXJzLCBnaXZlbiB0aGF0IHRoaXMgaXMgcHJldHR5IGdlbmVyaWMg c3R1ZmYuCgpBbGwgdGhhdCBsZWdhY3kgZmJkZXYgc3R1ZmYgaXMganVzdCBmb3IgbGVnYWN5IHN1 cHBvcnQsIGFuZCBJIHByZWZlciB0bwpoYXZlIHRoYXQgYXMgZHVtYiBhcyBwb3NzaWJsZS4gVGhl cmUncyBiZWVuIHNvbWUgZGlzY3Vzc2lvbiBldmVuIGFyb3VuZApsaWZ0aW5nIHRoZSAia2ljayBv dXQgZmlybXdhcmUgZmIgZHJpdmVyIiBvdXQgb2YgZmJkZXYsIHNpbmNlIHdlJ2QgbmVlZCBpdAp0 byBoYXZlIGEgc2ltcGxlIGRybSBkcml2ZXIgZm9yIGUuZy4gdWVmaS4KCkJ1dCBJIGRlZmluaXRl bHkgZG9uJ3Qgd2FudCBhIGxlZ2FjeSBob3Jyb3Igc2hvdyBsaWtlIGZiZGV2IHRvCmF1dG9tYWdp Y2FsbHkgdGFrZSBjYXJlIG9mIGRldmljZSBtYXBwaW5ncyBmb3IgZHJpdmVycy4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934060AbcDTLRh (ORCPT ); Wed, 20 Apr 2016 07:17:37 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37649 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933592AbcDTLRf (ORCPT ); Wed, 20 Apr 2016 07:17:35 -0400 Date: Wed, 20 Apr 2016 13:17:30 +0200 From: Daniel Vetter To: "Luis R. Rodriguez" Cc: Chris Wilson , David Airlie , netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ingo Molnar , "Peter Zijlstra (Intel)" , dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Daniel Vetter , Dan Williams , Yishai Hadas , David Hildenbrand Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA Message-ID: <20160420111730.GL2510@phenom.ffwll.local> Mail-Followup-To: "Luis R. Rodriguez" , Chris Wilson , David Airlie , netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ingo Molnar , "Peter Zijlstra (Intel)" , dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Daniel Vetter , Dan Williams , Yishai Hadas , David Hildenbrand References: <20160419123028.GI1990@wotan.suse.de> <1461069238-31539-1-git-send-email-chris@chris-wilson.co.uk> <1461069238-31539-4-git-send-email-chris@chris-wilson.co.uk> <20160420091054.GL1990@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160420091054.GL1990@wotan.suse.de> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote: > Reason I ask is since I noticed a while ago a lot of drivers > were using info->fix.smem_start and info->fix.smem_len consistently > for their ioremap'd areas it might make sense instead to let the > internal framebuffer (register_framebuffer()) optionally manage the > ioremap_wc() for drivers, given that this is pretty generic stuff. All that legacy fbdev stuff is just for legacy support, and I prefer to have that as dumb as possible. There's been some discussion even around lifting the "kick out firmware fb driver" out of fbdev, since we'd need it to have a simple drm driver for e.g. uefi. But I definitely don't want a legacy horror show like fbdev to automagically take care of device mappings for drivers. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto VMA Date: Wed, 20 Apr 2016 13:17:30 +0200 Message-ID: <20160420111730.GL2510@phenom.ffwll.local> References: <20160419123028.GI1990@wotan.suse.de> <1461069238-31539-1-git-send-email-chris@chris-wilson.co.uk> <1461069238-31539-4-git-send-email-chris@chris-wilson.co.uk> <20160420091054.GL1990@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: David Hildenbrand , netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Peter Zijlstra \(Intel\)" , Daniel Vetter , Dan Williams , Yishai Hadas , Ingo Molnar , linux-rdma@vger.kernel.org To: "Luis R. Rodriguez" Return-path: Content-Disposition: inline In-Reply-To: <20160420091054.GL1990@wotan.suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Id: netdev.vger.kernel.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMTE6MTA6NTRBTSArMDIwMCwgTHVpcyBSLiBSb2RyaWd1 ZXogd3JvdGU6Cj4gUmVhc29uIEkgYXNrIGlzIHNpbmNlIEkgbm90aWNlZCBhIHdoaWxlIGFnbyBh IGxvdCBvZiBkcml2ZXJzCj4gd2VyZSB1c2luZyBpbmZvLT5maXguc21lbV9zdGFydCBhbmQgaW5m by0+Zml4LnNtZW1fbGVuIGNvbnNpc3RlbnRseQo+IGZvciB0aGVpciBpb3JlbWFwJ2QgYXJlYXMg aXQgbWlnaHQgbWFrZSBzZW5zZSBpbnN0ZWFkIHRvIGxldCB0aGUKPiBpbnRlcm5hbCBmcmFtZWJ1 ZmZlciAocmVnaXN0ZXJfZnJhbWVidWZmZXIoKSkgb3B0aW9uYWxseSBtYW5hZ2UgdGhlCj4gaW9y ZW1hcF93YygpIGZvciBkcml2ZXJzLCBnaXZlbiB0aGF0IHRoaXMgaXMgcHJldHR5IGdlbmVyaWMg c3R1ZmYuCgpBbGwgdGhhdCBsZWdhY3kgZmJkZXYgc3R1ZmYgaXMganVzdCBmb3IgbGVnYWN5IHN1 cHBvcnQsIGFuZCBJIHByZWZlciB0bwpoYXZlIHRoYXQgYXMgZHVtYiBhcyBwb3NzaWJsZS4gVGhl cmUncyBiZWVuIHNvbWUgZGlzY3Vzc2lvbiBldmVuIGFyb3VuZApsaWZ0aW5nIHRoZSAia2ljayBv dXQgZmlybXdhcmUgZmIgZHJpdmVyIiBvdXQgb2YgZmJkZXYsIHNpbmNlIHdlJ2QgbmVlZCBpdAp0 byBoYXZlIGEgc2ltcGxlIGRybSBkcml2ZXIgZm9yIGUuZy4gdWVmaS4KCkJ1dCBJIGRlZmluaXRl bHkgZG9uJ3Qgd2FudCBhIGxlZ2FjeSBob3Jyb3Igc2hvdyBsaWtlIGZiZGV2IHRvCmF1dG9tYWdp Y2FsbHkgdGFrZSBjYXJlIG9mIGRldmljZSBtYXBwaW5ncyBmb3IgZHJpdmVycy4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==