From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>, Robert Richter <rric@kernel.org>,
oprofile-list@lists.sf.net, Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH 3/4] x86/intel lbr: down with test_thread_flag(TIF_IA32)
Date: Wed, 20 Apr 2016 13:21:52 +0200 [thread overview]
Message-ID: <20160420112152.GA3408@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALCETrUj2qnJ6HRLS3g19KEVf_uO4a96SkreJ4GAy0t1o6+prg@mail.gmail.com>
On Thu, Apr 14, 2016 at 12:29:12PM -0700, Andy Lutomirski wrote:
> On Thu, Apr 14, 2016 at 11:10 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> > @@ -724,7 +727,7 @@ static int branch_type(unsigned long from, unsigned long to, int abort)
> > * on 64-bit systems running 32-bit apps
> > */
> > #ifdef CONFIG_X86_64
> > - is64 = kernel_ip((unsigned long)addr) || !test_thread_flag(TIF_IA32);
> > + is64 = kernel_ip((unsigned long)addr) || user_64bit_mode(regs);
>
> Peterz, looking at this some more, would it make sense to pass
> user_regs and interrupt_regs (or whatever we'd call it) all the way
> through to here?
Urgh; again, wtf wasn't I Cc'ed to these patches?
And not sure; if we never need the user regs, calling
perf_get_user_regs() to set all that up seems like a massive waste of
cycles.
next prev parent reply other threads:[~2016-04-20 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 18:10 [PATCH 0/4] drop test_thread_flag checks Dmitry Safonov
2016-04-14 18:10 ` [PATCH 1/4] x86/events: down with test_thread_flag(TIF_IA32) Dmitry Safonov
2016-04-14 18:32 ` Andy Lutomirski
2016-04-20 11:15 ` Peter Zijlstra
2016-04-14 18:10 ` [PATCH 2/4] x86/intel: " Dmitry Safonov
2016-04-14 18:10 ` [PATCH 3/4] x86/intel lbr: " Dmitry Safonov
2016-04-14 19:29 ` Andy Lutomirski
2016-04-20 11:21 ` Peter Zijlstra [this message]
2016-04-20 13:43 ` Dmitry Safonov
2016-04-14 18:10 ` [PATCH 4/4] x86/oprofile: " Dmitry Safonov
2016-04-14 19:29 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420112152.GA3408@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=0x7f454c46@gmail.com \
--cc=dsafonov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.