From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1astQY-0006IR-3u
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:48:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1astQS-0004ES-Or
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 10:48:26 -0400
Date: Wed, 20 Apr 2016 10:48:13 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20160420144813.GB1109@localhost.localdomain>
References: <1461162766-907-1-git-send-email-kwolf@redhat.com>
	<1461162766-907-3-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461162766-907-3-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6 v3 2/3] iotests: Add
 iotests.image_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, famz@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org

On Wed, Apr 20, 2016 at 04:32:45PM +0200, Kevin Wolf wrote:
> From: Fam Zheng <famz@redhat.com>
> 
> This retrieves the virtual size of the image out of qemu-img info.
> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/iotests.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index d9ef60e..56f988a 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -28,6 +28,7 @@ sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'scripts', '
>  import qmp
>  import qtest
>  import struct
> +import json
>  
>  
>  # This will not work if arguments contain spaces but is necessary if we
> @@ -103,6 +104,11 @@ def create_image(name, size):
>          i = i + 512
>      file.close()
>  
> +def image_size(img):
> +    '''Return image's virtual size'''
> +    r = qemu_img_pipe('info', '--output=json', '-f', imgfmt, img)
> +    return json.loads(r)['virtual-size']
> +
>  test_dir_re = re.compile(r"%s" % test_dir)
>  def filter_test_dir(msg):
>      return test_dir_re.sub("TEST_DIR", msg)
> -- 
> 1.8.3.1
> 

Reviewed-by: Jeff Cody <jcody@redhat.com>