From: Andi Kleen <ak@linux.intel.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"eranian@google.com" <eranian@google.com>
Subject: Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL client uncore
Date: Wed, 20 Apr 2016 09:34:22 -0700 [thread overview]
Message-ID: <20160420163422.GA19706@tassilo.jf.intel.com> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077058E4102@SHSMSX103.ccr.corp.intel.com>
> Right. How about check the SKL_UNC_PERF_GLOBAL_CTL in enable_event?
> If it's cleared, we can reset it there. The drawback is that there will be an extra
> rdmsrl and a possible wrmsrl.
It's better to not rely on register state for this. There are a variety
of user space tools that manipulate the uncore MSRs through /dev/*/msr
So better keep software state. Software state is also much faster than
reading MSRs.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2016-04-20 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 8:23 [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL client uncore kan.liang
2016-04-20 13:28 ` Thomas Gleixner
2016-04-20 13:56 ` Liang, Kan
2016-04-20 14:54 ` Thomas Gleixner
2016-04-20 15:26 ` Liang, Kan
2016-04-21 8:03 ` Thomas Gleixner
2016-04-21 11:55 ` Liang, Kan
2016-04-20 16:34 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420163422.GA19706@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.