All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] package/radlib: new package
Date: Wed, 20 Apr 2016 17:59:00 +0200	[thread overview]
Message-ID: <20160420175900.2d55af03@free-electrons.com> (raw)
In-Reply-To: <1461167054.3415.27.camel@intel.com>

Hello,

On Wed, 20 Apr 2016 15:44:14 +0000, Kinsella, Ray wrote:

> Please ignore this patch, as the current radlib build results in an
> incorrect dynamic link table in librad. 
> 
> Lines like the following are just broken 
> 
> raddebug_LDADD   += -lmysqlclient
> radmrouted_LDADD   += -lmysqlclient
> 
> or 
> 
> radmrouted_LDADD   += $(MYSQL_LIBS)
> raddebug_LDADD   += $(MYSQL_LIBS)
> 
> The radlib library (librad.so) should link against
> mysql/sqlite/postgresql. The radlib executables (shown above) should
> then link again radlib (librad.so). 

There were some other issues in your patch, and I was planning to
review it. I'll try to give you some feedback so that you can take it
into account for your v6.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-20 15:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 16:06 [Buildroot] [PATCH v5] package/radlib: new package ray.kinsella at intel.com
2016-04-13 16:06 ` ray.kinsella at intel.com
2016-04-21 23:02   ` Arnout Vandecappelle
2016-04-24 15:15     ` Kinsella, Ray
2016-05-02 20:44       ` Arnout Vandecappelle
2016-06-14 14:20         ` Kinsella, Ray
2016-04-20 15:44 ` Kinsella, Ray
2016-04-20 15:59   ` Thomas Petazzoni [this message]
2016-04-24 14:49     ` Kinsella, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160420175900.2d55af03@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.