From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc() Date: Wed, 20 Apr 2016 20:58:44 +0200 Message-ID: <20160420185844.GQ1990@wotan.suse.de> References: <1461177750-20187-1-git-send-email-chris@chris-wilson.co.uk> <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ingo Molnar , "Peter Zijlstra (Intel)" , "Luis R . Rodriguez" , dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Daniel Vetter , Dan Williams , Yishai Hadas , David Hildenbrand List-Id: linux-rdma@vger.kernel.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDc6NDI6MTNQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBpb3JlbWFwKCkgaGlkZGVuIGJlaGluZCB0aGUgaW9fbWFwcGluZ19tYXBfd2Mo KSBjb252ZW5pZW5jZSBoZWxwZXIKPiBjYW4gYmUgdXNlZCBmb3IgcmVtYXBwaW5nIG11bHRpcGxl IHBhZ2VzLiBFeHRlbmQgdGhlIGhlbHBlciBzbyB0aGF0Cj4gZnV0dXJlIGNhbGxlcnMgY2FuIHVz ZSBpdCBmb3IgbGFyZ2VyIHJhbmdlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4g Q2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogWWlzaGFpIEhhZGFzIDx5 aXNoYWloQG1lbGxhbm94LmNvbT4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0Bp bnRlbC5jb20+Cj4gQ2M6IEluZ28gTW9sbmFyIDxtaW5nb0BrZXJuZWwub3JnPgo+IENjOiAiUGV0 ZXIgWmlqbHN0cmEgKEludGVsKSIgPHBldGVyekBpbmZyYWRlYWQub3JnPgo+IENjOiBEYXZpZCBI aWxkZW5icmFuZCA8ZGFoaUBsaW51eC52bmV0LmlibS5jb20+Cj4gQ2M6IEx1aXMgUi4gUm9kcmln dWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4KPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IG5ldGRldkB2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtcmRtYUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGlu dXgta2VybmVsQHZnZXIua2VybmVsLm9yZwoKV2UgaGF2ZSAyIGNhbGxlcnMgdG9kYXksIGluIHRo ZSBmdXR1cmUsIGNhbiB5b3UgZW52aXNpb24KdGhpcyBBUEkgZ2V0dGluZyBtb3JlIG9wdGlvbnM/ IElmIHNvLCBpbiBvcmRlciB0byBhdm9pZCB0aGUKcGFpbiBvZiBjb2xsYXRlcmFsIGV2b2x1dGlv bnMgSSBjYW4gc3VnZ2VzdCBhIGRlc2NyaXB0b3IKYmVpbmcgcGFzc2VkIHdpdGggdGhlIHJlcXVp cmVkIHNldHRpbmdzIC8gb3B0aW9ucy4gVGhpcyBsZXRzCnlvdSBldm9sdmUgdGhlIEFQSSB3aXRo b3V0IG5lZWRpbmcgdG8gZ28gaW4gYW5kIG1vZGlmeQpvbGQgdXNlcnMuIElmIHlvdSBjaG9vc2Ug bm90IHRvIHRoYXQncyBmaW5lIHRvbywganVzdApmaWd1cmVkIEknZCBjaGltZSBpbiB3aXRoIHRo YXQgYXMgSSd2ZSBzZWVuIHRoZSBwYWluCndpdGggb3RoZXIgQVBJcywgYW5kIEknbSBwdXR0aW5n IGFuIGVuZCB0byB0aGUgbmVlZGxlc3MKc2V0IG9mIGNvbGxhdGVyYWwgZXZvbHV0aW9ucyB0aGlz IHdheS4KCk90aGVyIHRoYW4gdGhhdCBwb3NzaWJsZSBBUEkgb3B0aW1pemF0aW9uOgoKUmV2aWV3 ZWQtYnk6IEx1aXMgUi4gUm9kcmlndWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4KCiAgTHVpcwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbcDTS65 (ORCPT ); Wed, 20 Apr 2016 14:58:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:57754 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcDTS6z (ORCPT ); Wed, 20 Apr 2016 14:58:55 -0400 Date: Wed, 20 Apr 2016 20:58:44 +0200 From: "Luis R. Rodriguez" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Mika Kuoppala , Joonas Lahtinen , Tvrtko Ursulin , Daniel Vetter , Jani Nikula , David Airlie , Yishai Hadas , Dan Williams , Ingo Molnar , "Peter Zijlstra (Intel)" , David Hildenbrand , "Luis R . Rodriguez" , dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc() Message-ID: <20160420185844.GQ1990@wotan.suse.de> References: <1461177750-20187-1-git-send-email-chris@chris-wilson.co.uk> <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > can be used for remapping multiple pages. Extend the helper so that > future callers can use it for larger ranges. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: David Airlie > Cc: Yishai Hadas > Cc: Dan Williams > Cc: Ingo Molnar > Cc: "Peter Zijlstra (Intel)" > Cc: David Hildenbrand > Cc: Luis R. Rodriguez > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: linux-kernel@vger.kernel.org We have 2 callers today, in the future, can you envision this API getting more options? If so, in order to avoid the pain of collateral evolutions I can suggest a descriptor being passed with the required settings / options. This lets you evolve the API without needing to go in and modify old users. If you choose not to that's fine too, just figured I'd chime in with that as I've seen the pain with other APIs, and I'm putting an end to the needless set of collateral evolutions this way. Other than that possible API optimization: Reviewed-by: Luis R. Rodriguez Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH 02/19] io-mapping: Specify mapping size for io_mapping_map_wc() Date: Wed, 20 Apr 2016 20:58:44 +0200 Message-ID: <20160420185844.GQ1990@wotan.suse.de> References: <1461177750-20187-1-git-send-email-chris@chris-wilson.co.uk> <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ingo Molnar , "Peter Zijlstra \(Intel\)" , "Luis R . Rodriguez" , dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Daniel Vetter , Dan Williams , Yishai Hadas , David Hildenbrand To: Chris Wilson Return-path: Content-Disposition: inline In-Reply-To: <1461177750-20187-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" List-Id: netdev.vger.kernel.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDc6NDI6MTNQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBpb3JlbWFwKCkgaGlkZGVuIGJlaGluZCB0aGUgaW9fbWFwcGluZ19tYXBfd2Mo KSBjb252ZW5pZW5jZSBoZWxwZXIKPiBjYW4gYmUgdXNlZCBmb3IgcmVtYXBwaW5nIG11bHRpcGxl IHBhZ2VzLiBFeHRlbmQgdGhlIGhlbHBlciBzbyB0aGF0Cj4gZnV0dXJlIGNhbGxlcnMgY2FuIHVz ZSBpdCBmb3IgbGFyZ2VyIHJhbmdlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4g Q2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogWWlzaGFpIEhhZGFzIDx5 aXNoYWloQG1lbGxhbm94LmNvbT4KPiBDYzogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0Bp bnRlbC5jb20+Cj4gQ2M6IEluZ28gTW9sbmFyIDxtaW5nb0BrZXJuZWwub3JnPgo+IENjOiAiUGV0 ZXIgWmlqbHN0cmEgKEludGVsKSIgPHBldGVyekBpbmZyYWRlYWQub3JnPgo+IENjOiBEYXZpZCBI aWxkZW5icmFuZCA8ZGFoaUBsaW51eC52bmV0LmlibS5jb20+Cj4gQ2M6IEx1aXMgUi4gUm9kcmln dWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4KPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IG5ldGRldkB2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtcmRtYUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGlu dXgta2VybmVsQHZnZXIua2VybmVsLm9yZwoKV2UgaGF2ZSAyIGNhbGxlcnMgdG9kYXksIGluIHRo ZSBmdXR1cmUsIGNhbiB5b3UgZW52aXNpb24KdGhpcyBBUEkgZ2V0dGluZyBtb3JlIG9wdGlvbnM/ IElmIHNvLCBpbiBvcmRlciB0byBhdm9pZCB0aGUKcGFpbiBvZiBjb2xsYXRlcmFsIGV2b2x1dGlv bnMgSSBjYW4gc3VnZ2VzdCBhIGRlc2NyaXB0b3IKYmVpbmcgcGFzc2VkIHdpdGggdGhlIHJlcXVp cmVkIHNldHRpbmdzIC8gb3B0aW9ucy4gVGhpcyBsZXRzCnlvdSBldm9sdmUgdGhlIEFQSSB3aXRo b3V0IG5lZWRpbmcgdG8gZ28gaW4gYW5kIG1vZGlmeQpvbGQgdXNlcnMuIElmIHlvdSBjaG9vc2Ug bm90IHRvIHRoYXQncyBmaW5lIHRvbywganVzdApmaWd1cmVkIEknZCBjaGltZSBpbiB3aXRoIHRo YXQgYXMgSSd2ZSBzZWVuIHRoZSBwYWluCndpdGggb3RoZXIgQVBJcywgYW5kIEknbSBwdXR0aW5n IGFuIGVuZCB0byB0aGUgbmVlZGxlc3MKc2V0IG9mIGNvbGxhdGVyYWwgZXZvbHV0aW9ucyB0aGlz IHdheS4KCk90aGVyIHRoYW4gdGhhdCBwb3NzaWJsZSBBUEkgb3B0aW1pemF0aW9uOgoKUmV2aWV3 ZWQtYnk6IEx1aXMgUi4gUm9kcmlndWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4KCiAgTHVpcwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK