From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 1/3] staging/android: remove redundant comments on sync_merge_data Date: Wed, 20 Apr 2016 16:30:34 -0300 Message-ID: <20160420193034.GA2392@joana> References: <1461179926-20542-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com [209.85.161.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 701A16EAF9 for ; Wed, 20 Apr 2016 19:30:39 +0000 (UTC) Received: by mail-yw0-f194.google.com with SMTP id o63so8610591ywe.0 for ; Wed, 20 Apr 2016 12:30:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1461179926-20542-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SSBtZXNzZWQgdXAgd2l0aCB0aGUgc3ViamVjdCBwcmVmaXgsIGJ1dCB0aGlzIGlzIHYxMSwgYWRk cyB0eXBlY2hlY2soKQp0byBwYXRjaCAyLgoKMjAxNi0wNC0yMCBHdXN0YXZvIFBhZG92YW4gPGd1 c3Rhdm9AcGFkb3Zhbi5vcmc+OgoKPiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFk b3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gCj4gc3RydWN0IHN5bmNfbWVyZ2VfZGF0YSBhbHJlYWR5 IGhhdmUgZG9jdW1lbnRhdGlvbiBvbiB0b3Agb2YgdGhlCj4gc3RydWN0IGRlZmluaXRpb24uIE5v IG5lZWQgdG8gZHVwbGljYXRlIGl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gUGFkb3Zh biA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiBSZXZpZXdlZC1ieTogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvdWFwaS9zeW5jLmggfCA2ICsrKy0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC91YXBpL3N5bmMuaCBiL2RyaXZlcnMvc3RhZ2luZy9h bmRyb2lkL3VhcGkvc3luYy5oCj4gaW5kZXggYTBjZjM1Ny4uNDQ2N2M3NiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC91YXBpL3N5bmMuaAo+ICsrKyBiL2RyaXZlcnMvc3Rh Z2luZy9hbmRyb2lkL3VhcGkvc3luYy5oCj4gQEAgLTIxLDkgKzIxLDkgQEAKPiAgICogQGZlbmNl OglyZXR1cm5zIHRoZSBmZCBvZiB0aGUgbmV3IGZlbmNlIHRvIHVzZXJzcGFjZQo+ICAgKi8KPiAg c3RydWN0IHN5bmNfbWVyZ2VfZGF0YSB7Cj4gLQlfX3MzMglmZDI7IC8qIGZkIG9mIHNlY29uZCBm ZW5jZSAqLwo+IC0JY2hhcgluYW1lWzMyXTsgLyogbmFtZSBvZiBuZXcgZmVuY2UgKi8KPiAtCV9f czMyCWZlbmNlOyAvKiBmZCBvbiBuZXdseSBjcmVhdGVkIGZlbmNlICovCj4gKwlfX3MzMglmZDI7 Cj4gKwljaGFyCW5hbWVbMzJdOwo+ICsJX19zMzIJZmVuY2U7Cj4gIH07Cj4gIAo+ICAvKioKPiAt LSAKPiAyLjUuNQo+IAoKCUd1c3Rhdm8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbcDTTfB (ORCPT ); Wed, 20 Apr 2016 15:35:01 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:33502 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbcDTTaj (ORCPT ); Wed, 20 Apr 2016 15:30:39 -0400 Date: Wed, 20 Apr 2016 16:30:34 -0300 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: Re: [PATCH 1/3] staging/android: remove redundant comments on sync_merge_data Message-ID: <20160420193034.GA2392@joana> Mail-Followup-To: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan References: <1461179926-20542-1-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461179926-20542-1-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I messed up with the subject prefix, but this is v11, adds typecheck() to patch 2. 2016-04-20 Gustavo Padovan : > From: Gustavo Padovan > > struct sync_merge_data already have documentation on top of the > struct definition. No need to duplicate it. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Maarten Lankhorst > --- > drivers/staging/android/uapi/sync.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h > index a0cf357..4467c76 100644 > --- a/drivers/staging/android/uapi/sync.h > +++ b/drivers/staging/android/uapi/sync.h > @@ -21,9 +21,9 @@ > * @fence: returns the fd of the new fence to userspace > */ > struct sync_merge_data { > - __s32 fd2; /* fd of second fence */ > - char name[32]; /* name of new fence */ > - __s32 fence; /* fd on newly created fence */ > + __s32 fd2; > + char name[32]; > + __s32 fence; > }; > > /** > -- > 2.5.5 > Gustavo