From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io Date: Wed, 20 Apr 2016 13:59:23 -0700 Message-ID: <20160420205923.GA24797@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vishal Verma , Christoph Hellwig , Jan Kara , linux-nvdimm@ml01.01.org, Dave Chinner , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Jens Axboe , linux-mm@kvack.org, linux-block@vger.kernel.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Al Viro To: Jeff Moyer Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Fri, Apr 15, 2016 at 12:11:36PM -0400, Jeff Moyer wrote: > > + if (IS_DAX(inode)) { > > + ret = dax_do_io(iocb, inode, iter, offset, blkdev_get_block, > > NULL, DIO_SKIP_DIO_COUNT); > > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE)) > > + ret_saved = ret; > > + else > > + return ret; > > + } > > + > > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode), iter, offset, > > blkdev_get_block, NULL, NULL, > > DIO_SKIP_DIO_COUNT); > > + if (ret < 0 && ret_saved) > > + return ret_saved; > > + > > Hmm, did you just break async DIO? I think you did! :) > __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned that > into -EIO. Really, I don't see a reason to save that first -EIO. The > same applies to all instances in this patch. Yes, there is no point in saving the earlier error - just return the second error all the time. E.g. ret = dax_io(); if (dax_need_dio_retry(ret)) ret = direct_IO(); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id C0D287CA0 for ; Wed, 20 Apr 2016 15:59:32 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 79A2930404E for ; Wed, 20 Apr 2016 13:59:29 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id FoGp5S9SJa8u5jVU (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 20 Apr 2016 13:59:27 -0700 (PDT) Date: Wed, 20 Apr 2016 13:59:23 -0700 From: Christoph Hellwig Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io Message-ID: <20160420205923.GA24797@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Moyer Cc: Jens Axboe , Jan Kara , Vishal Verma , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Christoph Hellwig , linux-mm@kvack.org, linux-block@vger.kernel.org, Matthew Wilcox , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Al Viro On Fri, Apr 15, 2016 at 12:11:36PM -0400, Jeff Moyer wrote: > > + if (IS_DAX(inode)) { > > + ret = dax_do_io(iocb, inode, iter, offset, blkdev_get_block, > > NULL, DIO_SKIP_DIO_COUNT); > > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE)) > > + ret_saved = ret; > > + else > > + return ret; > > + } > > + > > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode), iter, offset, > > blkdev_get_block, NULL, NULL, > > DIO_SKIP_DIO_COUNT); > > + if (ret < 0 && ret_saved) > > + return ret_saved; > > + > > Hmm, did you just break async DIO? I think you did! :) > __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned that > into -EIO. Really, I don't see a reason to save that first -EIO. The > same applies to all instances in this patch. Yes, there is no point in saving the earlier error - just return the second error all the time. E.g. ret = dax_io(); if (dax_need_dio_retry(ret)) ret = direct_IO(); _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbcDTU72 (ORCPT ); Wed, 20 Apr 2016 16:59:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45362 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbcDTU70 (ORCPT ); Wed, 20 Apr 2016 16:59:26 -0400 Date: Wed, 20 Apr 2016 13:59:23 -0700 From: Christoph Hellwig To: Jeff Moyer Cc: Vishal Verma , Christoph Hellwig , Jan Kara , linux-nvdimm@ml01.01.org, Dave Chinner , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Jens Axboe , linux-mm@kvack.org, linux-block@vger.kernel.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Al Viro Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io Message-ID: <20160420205923.GA24797@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 12:11:36PM -0400, Jeff Moyer wrote: > > + if (IS_DAX(inode)) { > > + ret = dax_do_io(iocb, inode, iter, offset, blkdev_get_block, > > NULL, DIO_SKIP_DIO_COUNT); > > + if (ret == -EIO && (iov_iter_rw(iter) == WRITE)) > > + ret_saved = ret; > > + else > > + return ret; > > + } > > + > > + ret = __blockdev_direct_IO(iocb, inode, I_BDEV(inode), iter, offset, > > blkdev_get_block, NULL, NULL, > > DIO_SKIP_DIO_COUNT); > > + if (ret < 0 && ret_saved) > > + return ret_saved; > > + > > Hmm, did you just break async DIO? I think you did! :) > __blockdev_direct_IO can return -EIOCBQUEUED, and you've now turned that > into -EIO. Really, I don't see a reason to save that first -EIO. The > same applies to all instances in this patch. Yes, there is no point in saving the earlier error - just return the second error all the time. E.g. ret = dax_io(); if (dax_need_dio_retry(ret)) ret = direct_IO();