From: Brian Norris <briannorris@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Olof Johansson <olof@lixom.net>,
dianders@chromium.org, gwendal@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: platform/chrome: cros_ec_dev - Populate compat_ioctl
Date: Wed, 20 Apr 2016 14:45:13 -0700 [thread overview]
Message-ID: <20160420214513.GA78825@google.com> (raw)
In-Reply-To: <1460687729-5860-1-git-send-email-linux@roeck-us.net>
On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> compat_ioctl has to be populated for 32 bit userspace applications to work
> with 64 bit kernels.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested with 32-bit user space on ARM64:
Tested-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index 6c45e0f5ba7b..903b1d8dcab7 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -208,6 +208,9 @@ static const struct file_operations fops = {
> .release = ec_device_release,
> .read = ec_device_read,
> .unlocked_ioctl = ec_device_ioctl,
> +#ifdef CONFIG_COMPAT
> + .compat_ioctl = ec_device_ioctl,
> +#endif
> };
>
> static void __remove(struct device *dev)
next prev parent reply other threads:[~2016-04-20 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 2:35 [PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl Guenter Roeck
2016-04-20 21:45 ` Brian Norris [this message]
2016-05-11 18:33 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420214513.GA78825@google.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.