From: Eduardo Valentin <edubezval@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: jic23@kernel.org, robh@kernel.org, rui.zhang@intel.com,
mark.rutland@arm.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver
Date: Wed, 20 Apr 2016 16:43:23 -0700 [thread overview]
Message-ID: <20160420234322.GA2558@localhost.localdomain> (raw)
In-Reply-To: <1461050521-6080-2-git-send-email-ldewangan@nvidia.com>
Laxman,
On Tue, Apr 19, 2016 at 12:52:01PM +0530, Laxman Dewangan wrote:
> In some of platform, thermal sensors like NCT thermistors are
> connected to the one of ADC channel. The temperature is read by
> reading the voltage across the sensor resistance via ADC. Lookup
> table for ADC read value to temperature is referred to get
> temperature. ADC is read via IIO framework.
>
> Add support for thermal sensor driver which read the voltage across
> sensor resistance from ADC through IIO framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
I really like this driver, as I mentioned before. Just one comment
though.
>
> +
> + gti->tz_dev = thermal_zone_of_sensor_register(&pdev->dev, 0,
> + gti, &gadc_thermal_ops);
Why not using the devm_ version you introduced?
Any particular reason?
next prev parent reply other threads:[~2016-04-20 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 7:22 [PATCH V4 1/2] thermal: generic-adc: Add DT binding for ADC based thermal sensor Laxman Dewangan
2016-04-19 7:22 ` Laxman Dewangan
2016-04-19 7:22 ` [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver Laxman Dewangan
2016-04-19 7:22 ` Laxman Dewangan
2016-04-19 19:02 ` Jonathan Cameron
2016-04-19 19:02 ` Jonathan Cameron
2016-04-20 23:43 ` Eduardo Valentin [this message]
2016-04-21 1:12 ` Laxman Dewangan
2016-04-21 1:12 ` Laxman Dewangan
2016-04-21 2:50 ` Eduardo Valentin
2016-04-21 2:50 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420234322.GA2558@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.