From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
Andreas Fenkart <afenkart@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 1/1] mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR upon error
Date: Thu, 21 Apr 2016 07:32:12 +0300 [thread overview]
Message-ID: <20160421043211.GS4247@mwanda> (raw)
In-Reply-To: <4155990.SfY6i69ddf@wuerfel>
On Thu, Apr 21, 2016 at 12:28:05AM +0200, Arnd Bergmann wrote:
> I don't see anything wrong with the devm_pinctrl_get prototype other
> than how it frequently confuses driver writers.
Yeah. It basically works. There are a bunch of similar APIs where NULL
vs ERR_PTR is used the same way.
regards,
dan carpenter
next prev parent reply other threads:[~2016-04-21 4:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 21:04 [PATCH v3 0/1] mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR Andreas Fenkart
2016-04-19 21:04 ` [PATCH v3 1/1] mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR upon error Andreas Fenkart
2016-04-19 22:03 ` kbuild test robot
2016-04-19 22:12 ` Arnd Bergmann
2016-04-20 8:11 ` Dan Carpenter
2016-04-20 11:38 ` Andreas Fenkart
2016-04-20 15:13 ` Tony Lindgren
2016-04-20 22:28 ` Arnd Bergmann
2016-04-21 4:32 ` Dan Carpenter [this message]
2016-04-19 22:15 ` kbuild test robot
2016-04-19 22:19 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421043211.GS4247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=afenkart@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.